[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

Eric Christopher echristo at gmail.com
Mon Mar 2 12:59:27 PST 2015


Couple inline comments.

-eric


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:587
@@ -584,2 +586,3 @@
 
-      setOperationAction(ISD::SETCC, MVT::v2i64, Custom);
+      if (Subtarget.hasP8Altivec()) {
+        setOperationAction(ISD::SETCC, MVT::v2i64, Legal);
----------------
Also maybe unify these above?

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7037
@@ -7029,3 +7036,3 @@
 static bool getAltivecCompareInfo(SDValue Intrin, int &CompareOpc,
-                                  bool &isDot) {
+                                  bool &isDot, const PPCSubtarget &subtarget) {
   unsigned IntrinsicID =
----------------
"Subtarget" or "STI" are the more common spellings.

http://reviews.llvm.org/D7959

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list