[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

[Bill Schmidt]

Other than style issues called out inline, and the open question about PPCSchedule.td for Hal, this LGTM.


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:578
@@ -577,3 +577,3 @@
       // VSX v2i64 only supports non-arithmetic operations.
-      setOperationAction(ISD::ADD, MVT::v2i64, Expand);
-      setOperationAction(ISD::SUB, MVT::v2i64, Expand);
+      if (! Subtarget.hasP8Altivec()) {
+        setOperationAction(ISD::ADD, MVT::v2i64, Expand);
----------------
You haven't fixed echristo's whitespace comment.  (No space between the ! and the target of the bang.)

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7055
@@ +7054,3 @@
+    }
+    else {
+      return false;
----------------
Style: No braces around a single statement.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7069
@@ +7068,3 @@
+    }
+    else {
+      return false;
----------------
No braces.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7081
@@ +7080,3 @@
+    }
+    else {
+      return false;
----------------
No braces.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:7097
@@ +7096,3 @@
+    }
+    else {
+      return false;
----------------
Etc.  I'll stop now... ;)

http://reviews.llvm.org/D7959

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/