[PATCH] [ELF][X86_64] Handle R_X86_64_PC64 relocation

Shankar Easwaran shankare at codeaurora.org
Thu Feb 26 16:55:40 PST 2015


Why big endian ?

On 2/26/2015 6:53 PM, Rui Ueyama wrote:
> Can we add llvm::support::endian::read{le,be}{16,32,64}(void *)
> and llvm::support::endian::write{le,be}{16,32,64}(void *, uint64_t)?
>
> On Thu, Feb 26, 2015 at 4:04 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>> On Thu, Feb 26, 2015 at 3:58 PM, Sean Silva <chisophugis at gmail.com> wrote:
>>
>>> REPOSITORY
>>>    rL LLVM
>>>
>>> ================
>>> Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:64
>>> @@ +63,3 @@
>>> +      result |
>>> +      (uint64_t) * reinterpret_cast<llvm::support::ulittle64_t
>>> *>(location);
>>> +}
>>> ----------------
>>> davide wrote:
>>>> ruiu wrote:
>>>>> Not sure if clang-format formatted like this, but I think there
>>> should be no space around "*".
>>>> Ditto. No, it did not, I tried to be consistent to what was already
>>> there.
>>> Can you just use endian::read and endian::write functions?
>>
>> Is
>>
>>    llvm::support::endian::write<uint64_t, support::little,
>> support::unaligned>(location)
>>
>> better than
>>
>>    (uint64_t)*reinterpret_cast<llvm::support::ulittle64_t *>(location)
>>
>> ?
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150226/47c8e4ba/attachment.html>


More information about the llvm-commits mailing list