<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Why big endian ?<br>
<br>
On 2/26/2015 6:53 PM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:CAJENXgt6htR88bWvBPxGqYnH2qkk+So81CpfXGvVPdzD1LM1NQ@mail.gmail.com"
type="cite">
<pre wrap="">Can we add llvm::support::endian::read{le,be}{16,32,64}(void *)
and llvm::support::endian::write{le,be}{16,32,64}(void *, uint64_t)?
On Thu, Feb 26, 2015 at 4:04 PM, Rui Ueyama <a class="moz-txt-link-rfc2396E" href="mailto:ruiu@google.com"><ruiu@google.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Thu, Feb 26, 2015 at 3:58 PM, Sean Silva <a class="moz-txt-link-rfc2396E" href="mailto:chisophugis@gmail.com"><chisophugis@gmail.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">REPOSITORY
rL LLVM
================
Comment at: lib/ReaderWriter/ELF/X86_64/X86_64RelocationHandler.cpp:64
@@ +63,3 @@
+ result |
+ (uint64_t) * reinterpret_cast<llvm::support::ulittle64_t
*>(location);
+}
----------------
davide wrote:
</pre>
<blockquote type="cite">
<pre wrap="">ruiu wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Not sure if clang-format formatted like this, but I think there
</pre>
</blockquote>
</blockquote>
<pre wrap="">should be no space around "*".
</pre>
<blockquote type="cite">
<pre wrap="">Ditto. No, it did not, I tried to be consistent to what was already
</pre>
</blockquote>
<pre wrap="">there.
Can you just use endian::read and endian::write functions?
</pre>
</blockquote>
<pre wrap="">
Is
llvm::support::endian::write<uint64_t, support::little,
support::unaligned>(location)
better than
(uint64_t)*reinterpret_cast<llvm::support::ulittle64_t *>(location)
?
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>