[PATCH] [opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

[David Blaikie]

On Thu, Feb 26, 2015 at 12:42 PM, Rafael Ávila de Espíndola <
rafael.espindola at gmail.com> wrote:

> ================
> Comment at: lib/AsmParser/LLParser.cpp:5368
> @@ +5367,3 @@
> +  Type *Ty = nullptr;
> +  if (ParseType(Ty)) return true;
> +  ParseToken(lltok::comma, "expected comma after getelementptr's type");
> ----------------
> clang-format please.
>

Formatted/refactored.


>
> ================
> Comment at: lib/AsmParser/LLParser.cpp:5377
> @@ +5376,3 @@
> +    PtrTy = VT->getElementType();
> +  assert(Ty == cast<SequentialType>(PtrTy)->getElementType());
> +
> ----------------
> This assert can fail on user input, no? It should be a real error report.
>

Yep, Duncan gave the same feedback - fixed and tested.


>
> http://reviews.llvm.org/D7636
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150226/c28e63d1/attachment.html>