[PATCH] [opaque pointer type] Add textual IR support for explicit type parameter to getelementptr instruction

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Thu Feb 26 12:42:19 PST 2015


================
Comment at: lib/AsmParser/LLParser.cpp:5368
@@ +5367,3 @@
+  Type *Ty = nullptr;
+  if (ParseType(Ty)) return true;
+  ParseToken(lltok::comma, "expected comma after getelementptr's type");
----------------
clang-format please.

================
Comment at: lib/AsmParser/LLParser.cpp:5377
@@ +5376,3 @@
+    PtrTy = VT->getElementType();
+  assert(Ty == cast<SequentialType>(PtrTy)->getElementType());
+
----------------
This assert can fail on user input, no? It should be a real error report.

http://reviews.llvm.org/D7636

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list