[llvm] r224782 - Finish removing DestroySource.

Chandler Carruth chandlerc at google.com
Tue Feb 24 16:52:24 PST 2015


On Tue, Feb 24, 2015 at 4:41 PM, Filip Pizlo <fpizlo at apple.com> wrote:

> > On Feb 24, 2015, at 4:39 PM, Hans Wennborg <hans at chromium.org> wrote:
> >
> > On Tue, Feb 24, 2015 at 3:46 PM, Filip Pizlo <fpizlo at apple.com> wrote:
> >> Proposed fix:
> >
> >> -                         unsigned Unused, char **OutMessages) {
> >> +                         LLVMLinkerMode Unused, char **OutMessages) {
> >
> > Do we really need to use the enum in the function prototype? Peter's
> > message suggests this might require a bindings update. The enumerators
> > should convert to unsigned anyway, right?
>
> WebKit points a pointer at this function, so the signature needs to stay
> the same.


It's a C function, so its really not clear why this should work without
source changes, and it should clearly work with source changes.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150224/8933ab3e/attachment.html>


More information about the llvm-commits mailing list