[llvm] r224782 - Finish removing DestroySource.
Filip Pizlo
fpizlo at apple.com
Tue Feb 24 16:41:19 PST 2015
> On Feb 24, 2015, at 4:39 PM, Hans Wennborg <hans at chromium.org> wrote:
>
> On Tue, Feb 24, 2015 at 3:46 PM, Filip Pizlo <fpizlo at apple.com> wrote:
>> Proposed fix:
>
>> - unsigned Unused, char **OutMessages) {
>> + LLVMLinkerMode Unused, char **OutMessages) {
>
> Do we really need to use the enum in the function prototype? Peter's
> message suggests this might require a bindings update. The enumerators
> should convert to unsigned anyway, right?
WebKit points a pointer at this function, so the signature needs to stay the same.
-Filip
More information about the llvm-commits
mailing list