[compiler-rt] r230019 - [ASan] Make the argument of '__sanitizer_annotate_contiguous_container' is not aligned error message easier to understand

Timur Iskhodzhanov timurrrr at google.com
Mon Feb 23 12:11:13 PST 2015


Isn't it rather a bug in the Report/Printf implementation?

[I assume the value of SHADOW_GRANULARITY can't be -1097502208 on ARM :)]

On Mon Feb 23 2015 at 10:56:15 PM Kostya Serebryany <kcc at google.com> wrote:

> Do I understand correctly, that the test broke on ARM because "long
> t[100]" is not necessary aligned by 8 on ARM?
>
> I agree that having bots red is important, but in this case it would have
> been better to actually fix the test than to roll-back the patch  (which is
> correct, but just uncovers the incompatibility of the test with ARM).
>
> Renato, may I ask you to fix the test for ARM and apply Timur's patch
> back?
> Not having access to ARM machine makes it harder for us to do.
>
>
> On Mon, Feb 23, 2015 at 3:07 AM, Renato Golin <renato.golin at linaro.org>
> wrote:
>
>> On 23 February 2015 at 11:03, Timur Iskhodzhanov <timurrrr at google.com>
>> wrote:
>> > Sorry for the breakage, I didn't get a failure email from the bot
>> [actually
>> > I did for the build #3843 but it was unrelated] and was on weekend when
>> you
>> > wrote me later.
>>
>> That's absolutely fine. That's what the buildbots are for, after all. :)
>>
>> Don't take reverts personal, they're not. Keeping the bots green is
>> essential, and we rather fix the issues offline than waiting too long.
>>
>> cheers,
>> --renato
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150223/83c2cd4f/attachment.html>


More information about the llvm-commits mailing list