[llvm] r229493 - Reformat.

[Lang Hames]

Hi Takumi, Yaron,

Takumi - thanks as always. Sorry to keep doing this to your bots.

Yaron - At the moment this code is only used in a hosted x86-64 JIT, so we
know that sizeof(uint64_t) == sizeof(uintptr_t). In the future It may be
changed to take CallbackAddr as a parameter, in order to support remote
jitting. Having the remote JIT case in mind, writing the pointer type as
uint64_t was reflex - it's the same style used by the rest of MCJIT and Orc.

Cheers,
Lang.


On Tue, Feb 17, 2015 at 5:07 AM, Yaron Keren <yaron.keren at gmail.com> wrote:

> Thanks Takumi!
>
> This code still assumes that sizeof(uint64_t) == sizeof(uintptr_t), not?
>
> Yaron
>
>
> 2015-02-17 14:53 GMT+02:00 NAKAMURA Takumi <geek4civic at gmail.com>:
>
>> Author: chapuni
>> Date: Tue Feb 17 06:53:05 2015
>> New Revision: 229493
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=229493&view=rev
>> Log:
>> Reformat.
>>
>> Modified:
>>     llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp
>>
>> Modified: llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp?rev=229493&r1=229492&r2=229493&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp (original)
>> +++ llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp Tue Feb 17
>> 06:53:05 2015
>> @@ -51,11 +51,9 @@ namespace llvm {
>>  const char* OrcX86_64::ResolverBlockName = "orc_resolver_block";
>>
>>  void OrcX86_64::insertResolverBlock(
>> -                               Module &M,
>> -                               JITCompileCallbackManagerBase<OrcX86_64>
>> &JCBM) {
>> -  uint64_t CallbackAddr =
>> -      static_cast<uint64_t>(
>> -        reinterpret_cast<uintptr_t>(executeCompileCallback<OrcX86_64>));
>> +    Module &M, JITCompileCallbackManagerBase<OrcX86_64> &JCBM) {
>> +  uint64_t CallbackAddr = static_cast<uint64_t>(
>> +      reinterpret_cast<uintptr_t>(executeCompileCallback<OrcX86_64>));
>>
>>    std::ostringstream AsmStream;
>>    Triple TT(M.getTargetTriple());
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150217/bbc4c44e/attachment.html>