<div dir="ltr">Hi Takumi, Yaron,<div><br></div><div>Takumi - thanks as always. Sorry to keep doing this to your bots.</div><div><br></div><div>Yaron - At the moment this code is only used in a hosted x86-64 JIT, so we know that sizeof(uint64_t) == sizeof(uintptr_t). In the future It may be changed to take CallbackAddr as a parameter, in order to support remote jitting. Having the remote JIT case in mind, writing the pointer type as uint64_t was reflex - it's the same style used by the rest of MCJIT and Orc.</div><div><br></div><div>Cheers,</div><div>Lang.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 17, 2015 at 5:07 AM, Yaron Keren <span dir="ltr"><<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">Thanks Takumi!</div><div dir="ltr"><br></div><div dir="ltr">This code still assumes that sizeof(<span style="font-size:12.8000001907349px">uint64_t) == sizeof(</span><span style="font-size:12.8000001907349px">uintptr_t</span><span style="font-size:12.8000001907349px">), not?</span></div><span class="HOEnZb"><font color="#888888"><div dir="ltr"><br></div><div dir="ltr"><span style="font-size:12.8000001907349px">Yaron</span></div><div dir="ltr"><span style="font-size:12.8000001907349px"><br></span></div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-02-17 14:53 GMT+02:00 NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br>
Date: Tue Feb 17 06:53:05 2015<br>
New Revision: 229493<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=229493&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=229493&view=rev</a><br>
Log:<br>
Reformat.<br>
<br>
Modified:<br>
llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp?rev=229493&r1=229492&r2=229493&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp?rev=229493&r1=229492&r2=229493&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/Orc/OrcTargetSupport.cpp Tue Feb 17 06:53:05 2015<br>
@@ -51,11 +51,9 @@ namespace llvm {<br>
const char* OrcX86_64::ResolverBlockName = "orc_resolver_block";<br>
<br>
void OrcX86_64::insertResolverBlock(<br>
- Module &M,<br>
- JITCompileCallbackManagerBase<OrcX86_64> &JCBM) {<br>
- uint64_t CallbackAddr =<br>
- static_cast<uint64_t>(<br>
- reinterpret_cast<uintptr_t>(executeCompileCallback<OrcX86_64>));<br>
+ Module &M, JITCompileCallbackManagerBase<OrcX86_64> &JCBM) {<br>
+ uint64_t CallbackAddr = static_cast<uint64_t>(<br>
+ reinterpret_cast<uintptr_t>(executeCompileCallback<OrcX86_64>));<br>
<br>
std::ostringstream AsmStream;<br>
Triple TT(M.getTargetTriple());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>