[PATCH] [LoopAccesses] Add canAnalyzeLoop

hfinkel at anl.gov hfinkel at anl.gov
Mon Feb 16 17:41:41 PST 2015


================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:835
@@ +834,3 @@
+  if (!TheLoop->empty()) {
+    emitAnalysis(VectorizationReport() << "loop is not the innermost loop");
+    return false;
----------------
anemet wrote:
> hfinkel wrote:
> > These should say LoopAccessReport(), not VectorizationReport(), right? Or do we have a special subclass for the analysis itslef? If not, maybe we should?
> > 
> Yes, these should be LoopAccessReport, thanks for noticing!
> 
> Also I just notices that the comment should be adjust not to mention vectorization in this context.
> 
> Why do you think that we'd need a subclass for the analysis?  The base class (LoopAccessReport) seems to be sufficient for now.
The vectorizer's subclass says something like "could not vectorize", should the analysis one say something like, "could not analyze for memory dependencies"? (just a though)

http://reviews.llvm.org/D7688

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list