[PATCH] [LoopAccesses] Add canAnalyzeLoop
Adam Nemet
anemet at apple.com
Mon Feb 16 17:36:10 PST 2015
================
Comment at: lib/Analysis/LoopAccessAnalysis.cpp:835
@@ +834,3 @@
+ if (!TheLoop->empty()) {
+ emitAnalysis(VectorizationReport() << "loop is not the innermost loop");
+ return false;
----------------
hfinkel wrote:
> These should say LoopAccessReport(), not VectorizationReport(), right? Or do we have a special subclass for the analysis itslef? If not, maybe we should?
>
Yes, these should be LoopAccessReport, thanks for noticing!
Also I just notices that the comment should be adjust not to mention vectorization in this context.
Why do you think that we'd need a subclass for the analysis? The base class (LoopAccessReport) seems to be sufficient for now.
http://reviews.llvm.org/D7688
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list