[PATCH] MemDepPrinter: Fix some nits introduced in r228596
Philip Reames
listmail at philipreames.com
Sun Feb 15 11:02:56 PST 2015
LGTM
FYI, post commit review would have been fine for white space changes.
On 02/14/2015 12:06 PM, Ramkumar Ramachandra wrote:
> Hi dexonsmith,
>
> http://reviews.llvm.org/D7644
>
> Files:
> lib/Analysis/MemDepPrinter.cpp
>
> Index: lib/Analysis/MemDepPrinter.cpp
> ===================================================================
> --- lib/Analysis/MemDepPrinter.cpp
> +++ lib/Analysis/MemDepPrinter.cpp
> @@ -96,7 +96,7 @@
>
> // All this code uses non-const interfaces because MemDep is not
> // const-friendly, though nothing is actually modified.
> - for (auto &I: inst_range(F)) {
> + for (auto &I : inst_range(F)) {
> Instruction *Inst = &I;
>
> if (!Inst->mayReadFromMemory() && !Inst->mayWriteToMemory())
> @@ -135,16 +135,16 @@
> }
>
> void MemDepPrinter::print(raw_ostream &OS, const Module *M) const {
> - for (auto &I: inst_range(*F)) {
> + for (const auto &I : inst_range(*F)) {
> const Instruction *Inst = &I;
>
> DepSetMap::const_iterator DI = Deps.find(Inst);
> if (DI == Deps.end())
> continue;
>
> const DepSet &InstDeps = DI->second;
>
> - for (auto &I: InstDeps) {
> + for (const auto &I : InstDeps) {
> const Instruction *DepInst = I.first.getPointer();
> DepType type = I.first.getInt();
> const BasicBlock *DepBB = I.second;
>
> EMAIL PREFERENCES
> http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150215/d143984f/attachment.html>
More information about the llvm-commits
mailing list