<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">LGTM<br>
<br>
FYI, post commit review would have been fine for white space
changes. <br>
<br>
On 02/14/2015 12:06 PM, Ramkumar Ramachandra wrote:<br>
</div>
<blockquote
cite="mid:differential-rev-PHID-DREV-jcbv7k264rrtdah3c3jm-req@reviews.llvm.org"
type="cite">
<pre wrap="">Hi dexonsmith,
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/D7644">http://reviews.llvm.org/D7644</a>
Files:
lib/Analysis/MemDepPrinter.cpp
Index: lib/Analysis/MemDepPrinter.cpp
===================================================================
--- lib/Analysis/MemDepPrinter.cpp
+++ lib/Analysis/MemDepPrinter.cpp
@@ -96,7 +96,7 @@
// All this code uses non-const interfaces because MemDep is not
// const-friendly, though nothing is actually modified.
- for (auto &I: inst_range(F)) {
+ for (auto &I : inst_range(F)) {
Instruction *Inst = &I;
if (!Inst->mayReadFromMemory() && !Inst->mayWriteToMemory())
@@ -135,16 +135,16 @@
}
void MemDepPrinter::print(raw_ostream &OS, const Module *M) const {
- for (auto &I: inst_range(*F)) {
+ for (const auto &I : inst_range(*F)) {
const Instruction *Inst = &I;
DepSetMap::const_iterator DI = Deps.find(Inst);
if (DI == Deps.end())
continue;
const DepSet &InstDeps = DI->second;
- for (auto &I: InstDeps) {
+ for (const auto &I : InstDeps) {
const Instruction *DepInst = I.first.getPointer();
DepType type = I.first.getInt();
const BasicBlock *DepBB = I.second;
EMAIL PREFERENCES
<a class="moz-txt-link-freetext" href="http://reviews.llvm.org/settings/panel/emailpreferences/">http://reviews.llvm.org/settings/panel/emailpreferences/</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>