[PATCH] Beginning of alloca implementation for Mips fast-isel

[Eric Christopher]

Hi Reed,

Some quick inline comments.

+      assert(isFIBase() && "Invalid base frame index  access!");

formatting.

-  const MipsSubtarget *Subtarget;
   const TargetInstrInfo &TII;
   const TargetLowering &TLI;
+  const MipsSubtarget *Subtarget;

Unnecessary.

+        Subtarget(&TM.getSubtarget<MipsSubtarget>()) {

No.

+    TargetSupported = ((Subtarget->getRelocationModel() == Reloc::PIC_) &&
+                       ((Subtarget->hasMips32r2() ||
Subtarget->hasMips32()) &&
+                        (Subtarget->isABI_O32())));

Ditto.

+  // This code is mostly cloned from AArch64 (which cloned it from earlier
+  // ports)'

Unnecessary.

+    unsigned Offset = Addr.getOffset();
+    ;
+    MachineFrameInfo &MFI = *MF->getFrameInfo();
+    ;

?

-eric

On Fri Feb 13 2015 at 3:17:20 PM reed kotler <rkotler at mips.com> wrote:

> Run clang format on patch.
>
>
> http://reviews.llvm.org/D6426
>
> Files:
>   lib/Target/Mips/MipsFastISel.cpp
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150213/33f3da85/attachment.html>