[PATCH] Beginning of alloca implementation for Mips fast-isel

[Eric Christopher]

Hi Reed,

Some quick inline comments.

+      assert(isFIBase() && "Invalid base frame index  access!");

formatting.

- const MipsSubtarget *Subtarget; const TargetInstrInfo &TII; const TargetLowering &TLI;

+  const MipsSubtarget *Subtarget;

Unnecessary.

+        Subtarget(&TM.getSubtarget<MipsSubtarget>()) {

No.

+    TargetSupported = ((Subtarget->getRelocationModel() == Reloc::PIC_) &&
+                       ((Subtarget->hasMips32r2() ||
Subtarget->hasMips32()) &&
+                        (Subtarget->isABI_O32())));

Ditto.

+  // This code is mostly cloned from AArch64 (which cloned it from earlier
+  // ports)'

Unnecessary.

+    unsigned Offset = Addr.getOffset();
+    ;
+    MachineFrameInfo &MFI = *MF->getFrameInfo();
+    ;

?

-eric


http://reviews.llvm.org/D6426

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/