[PATCH] Update ARM and x86 ArchHandler to match 64bits counterparts. NFC
Jean-Daniel Dupas
mailing at xenonium.com
Fri Feb 13 07:03:03 PST 2015
In http://reviews.llvm.org/D7612#123205, @shankarke wrote:
> not sure if its common coding practice to use return instead of break in switch statements.
I don't know if this is a common practice but it matches the x86_64 and ARM64 ArchHandlers.
REPOSITORY
rL LLVM
================
Comment at: lib/ReaderWriter/MachO/ArchHandler_arm.cpp:916
@@ -914,3 +915,3 @@
uint32_t value32;
- switch (ref.kindValue()) {
+ switch (static_cast<Arm_Kinds>(ref.kindValue())) {
case modeThumbCode:
----------------
shankarke wrote:
> There is an assert at line 911, that takes care of making sure all the kinds are specific to ARM, no ?
assert are runtime error and are not a replacement for proper compile time warning IMHO.
http://reviews.llvm.org/D7612
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list