[PATCH] Update ARM and x86 ArchHandler to match 64bits counterparts. NFC
Shankar Kalpathi Easwaran
shankarke at gmail.com
Fri Feb 13 06:57:15 PST 2015
not sure if its common coding practice to use return instead of break in switch statements.
REPOSITORY
rL LLVM
================
Comment at: lib/ReaderWriter/MachO/ArchHandler_arm.cpp:916
@@ -914,3 +915,3 @@
uint32_t value32;
- switch (ref.kindValue()) {
+ switch (static_cast<Arm_Kinds>(ref.kindValue())) {
case modeThumbCode:
----------------
There is an assert at line 911, that takes care of making sure all the kinds are specific to ARM, no ?
http://reviews.llvm.org/D7612
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list