[PATCH] Implementation of relocations: R_ARM_REL32, R_ARM_THM_JUMP11, R_ARM_PREL31 for ELF/ARM

[Michael Spencer]

looks fine other than what I mention inline.


REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp:121
@@ -120,1 +120,3 @@
 
+static inline void applyThmReloc(uint8_t *location, uint16_t result,
+                                 uint16_t mask = 0xFFFF) {
----------------
applyThumbReloc

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp:123
@@ +122,3 @@
+                                 uint16_t mask = 0xFFFF) {
+  assert(!(result & ~mask));
+  *reinterpret_cast<llvm::support::ulittle16_t *>(location) =
----------------
Is this checked before here? Bad input shouldn't assert, it should report a proper error.

http://reviews.llvm.org/D7565

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/