[PATCH] Implementation of relocations: R_ARM_REL32, R_ARM_THM_JUMP11, R_ARM_PREL31 for ELF/ARM

[Shankar Kalpathi Easwaran]

REPOSITORY
  rL LLVM

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp:245-246
@@ +244,4 @@
+
+  if (needVeneer)
+    return make_out_of_range_reloc_error();
+
----------------
Why isnt a veneer being created for this ?

================
Comment at: lib/ReaderWriter/ELF/ARM/ARMRelocationHandler.cpp:446-450
@@ +445,7 @@
+  {
+    std::error_code error = relocR_ARM_THM_JUMP11(location, relocVAddress,
+                              targetVAddress, addend, addressesThumb);
+
+    if (error != std::error_code())
+      return error;
+
----------------
can be done in one line

if (std::error_code ec= function)
return ec;

http://reviews.llvm.org/D7565

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/