[PATCH] Fix llvm::sys::path::home_directory on unix to get path from passwd.pw_dir when the $HOME variable isn't set
Chandler Carruth
chandlerc at gmail.com
Tue Feb 10 22:30:44 PST 2015
On Tue, Feb 10, 2015 at 9:34 PM, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> A few comments:
>
> - Use clang-format or manually follow the rules defined here:
> http://llvm.org/docs/CodingStandards.html
> - You are using a VLA, this is not C++ standard I believe.
> - At least add a clear comment on what you are doing and why (explain why
> getenv("HOME") might fail.
>
It's really unclear to me that we should support this at all rather. I feel
like we're adding complexity we really don't need.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150210/54919e81/attachment.html>
More information about the llvm-commits
mailing list