[PATCH] Fix llvm::sys::path::home_directory on unix to get path from passwd.pw_dir when the $HOME variable isn't set
Mehdi AMINI
mehdi.amini at apple.com
Tue Feb 10 21:34:06 PST 2015
A few comments:
- Use clang-format or manually follow the rules defined here: http://llvm.org/docs/CodingStandards.html
- You are using a VLA, this is not C++ standard I believe.
- At least add a clear comment on what you are doing and why (explain why getenv("HOME") might fail.
Thanks.
REPOSITORY
rL LLVM
http://reviews.llvm.org/D7515
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the llvm-commits
mailing list