[PATCH] AsmWriter/Bitcode: Support specialized debug nodes

[David Blaikie]

On Tue, Feb 10, 2015 at 4:05 PM, Adrian Prantl <aprantl at apple.com> wrote:

> A few nitpicky suggestions and questions:
>
> - !MDSubrange(count: 30, lo: 2)
>   what about spelling out “low” and “high”?
>

+1


>
> - do we still need the uniqueID on MDLexicalBlock? Could it be a distinct
> node instead?
>

We might need to go back & figure out what that uniqueID is for - the
comments/code say something about templates, though I don't believe it
(template instantiations would be distinct functions, so the lexical blocks
would be distinct by virtue of referring to their distinct enclosing
scopes)...


>
> - is it possible to have it print DW_OP-* constants such as in
>   !MDExpression(DW_OP_deref, DW_OP_bit_piece, 0, 8)
>   ?
>
> Will it still print the old-style comments that testcases tend to match
> on, or are they obsoleted by the human-readable syntax?
>
> -- adrian
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150210/3df2389d/attachment.html>