[llvm] r228756 - Oops. Don't call Windows functions on non-windows.

David Blaikie dblaikie at gmail.com
Tue Feb 10 14:56:37 PST 2015


On Tue, Feb 10, 2015 at 2:47 PM, Zachary Turner <zturner at google.com> wrote:

> Author: zturner
> Date: Tue Feb 10 16:47:14 2015
> New Revision: 228756
>
> URL: http://llvm.org/viewvc/llvm-project?rev=228756&view=rev
> Log:
> Oops.  Don't call Windows functions on non-windows.
>
> Modified:
>     llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp
>
> Modified: llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp?rev=228756&r1=228755&r2=228756&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp (original)
> +++ llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp Tue Feb 10 16:47:14 2015
> @@ -15,6 +15,7 @@
>
>  #include "llvm/ADT/ArrayRef.h"
>  #include "llvm/ADT/StringExtras.h"
> +#include "llvm/Config/config.h"
>  #include "llvm/DebugInfo/PDB/PDB.h"
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
>  #include "llvm/DebugInfo/PDB/IPDBSession.h"
> @@ -30,7 +31,9 @@
>  #include "llvm/Support/PrettyStackTrace.h"
>  #include "llvm/Support/Signals.h"
>
> +#if defined(HAVE_DIA_SDK)
>

I'm assuming this logic will eventually be moved/built in to the DIA PDB
library implementation?


>  #include <Windows.h>
> +#endif
>
>  using namespace llvm;
>
> @@ -88,11 +91,16 @@ int main(int argc_, const char *argv_[])
>
>    cl::ParseCommandLineOptions(argv.size(), argv.data(), "LLVM PDB
> Dumper\n");
>
> +#if defined(HAVE_DIA_SDK)
>    CoInitializeEx(nullptr, COINIT_MULTITHREADED);
> +#endif
>
>    std::for_each(opts::InputFilenames.begin(), opts::InputFilenames.end(),
>                  dumpInput);
>
> +#if defined(HAVE_DIA_SDK)
>    CoUninitialize();
> +#endif
> +
>    return 0;
>  }
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150210/f5416d93/attachment.html>


More information about the llvm-commits mailing list