<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 10, 2015 at 2:47 PM, Zachary Turner <span dir="ltr"><<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: zturner<br>
Date: Tue Feb 10 16:47:14 2015<br>
New Revision: 228756<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228756&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=228756&view=rev</a><br>
Log:<br>
Oops.  Don't call Windows functions on non-windows.<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp?rev=228756&r1=228755&r2=228756&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp?rev=228756&r1=228755&r2=228756&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp (original)<br>
+++ llvm/trunk/tools/llvm-pdbdump/llvm-pdbdump.cpp Tue Feb 10 16:47:14 2015<br>
@@ -15,6 +15,7 @@<br>
<br>
 #include "llvm/ADT/ArrayRef.h"<br>
 #include "llvm/ADT/StringExtras.h"<br>
+#include "llvm/Config/config.h"<br>
 #include "llvm/DebugInfo/PDB/PDB.h"<br>
 #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"<br>
 #include "llvm/DebugInfo/PDB/IPDBSession.h"<br>
@@ -30,7 +31,9 @@<br>
 #include "llvm/Support/PrettyStackTrace.h"<br>
 #include "llvm/Support/Signals.h"<br>
<br>
+#if defined(HAVE_DIA_SDK)<br></blockquote><div><br>I'm assuming this logic will eventually be moved/built in to the DIA PDB library implementation?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
 #include <Windows.h><br>
+#endif<br>
<br>
 using namespace llvm;<br>
<br>
@@ -88,11 +91,16 @@ int main(int argc_, const char *argv_[])<br>
<br>
   cl::ParseCommandLineOptions(argv.size(), argv.data(), "LLVM PDB Dumper\n");<br>
<br>
+#if defined(HAVE_DIA_SDK)<br>
   CoInitializeEx(nullptr, COINIT_MULTITHREADED);<br>
+#endif<br>
<br>
   std::for_each(opts::InputFilenames.begin(), opts::InputFilenames.end(),<br>
                 dumpInput);<br>
<br>
+#if defined(HAVE_DIA_SDK)<br>
   CoUninitialize();<br>
+#endif<br>
+<br>
   return 0;<br>
 }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>