[llvm] r228490 - MC: Emit COFF section flags in the "proper" order

David Majnemer david.majnemer at gmail.com
Sat Feb 7 10:46:51 PST 2015


Hans,

Can you please merge this into the release branch?

On Sat, Feb 7, 2015 at 12:26 AM, David Majnemer <david.majnemer at gmail.com>
wrote:

> Author: majnemer
> Date: Sat Feb  7 02:26:40 2015
> New Revision: 228490
>
> URL: http://llvm.org/viewvc/llvm-project?rev=228490&view=rev
> Log:
> MC: Emit COFF section flags in the "proper" order
>
> COFF section flags are not idempotent:
>   'rd' will make a read-write section because 'd' implies write
>   'dr' will make a read-only section because 'r' disables write
>
> Modified:
>     llvm/trunk/lib/MC/MCSectionCOFF.cpp
>     llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll
>     llvm/trunk/test/CodeGen/ARM/Windows/structors.ll
>     llvm/trunk/test/CodeGen/X86/coff-comdat.ll
>     llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll
>     llvm/trunk/test/CodeGen/X86/dllexport.ll
>     llvm/trunk/test/CodeGen/X86/global-sections.ll
>     llvm/trunk/test/CodeGen/X86/win_cst_pool.ll
>     llvm/trunk/test/DebugInfo/COFF/asm.ll
>     llvm/trunk/test/DebugInfo/COFF/multifile.ll
>     llvm/trunk/test/DebugInfo/COFF/multifunction.ll
>     llvm/trunk/test/DebugInfo/COFF/simple.ll
>     llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll
>     llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll
>     llvm/trunk/test/MC/COFF/bss_section.ll
>     llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll
>     llvm/trunk/test/MC/COFF/global_ctors_dtors.ll
>     llvm/trunk/test/MC/COFF/initialised-data.ll
>     llvm/trunk/test/MC/COFF/section-passthru-flags.s
>
> Modified: llvm/trunk/lib/MC/MCSectionCOFF.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSectionCOFF.cpp?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/MC/MCSectionCOFF.cpp (original)
> +++ llvm/trunk/lib/MC/MCSectionCOFF.cpp Sat Feb  7 02:26:40 2015
> @@ -47,6 +47,10 @@ void MCSectionCOFF::PrintSwitchToSection
>    }
>
>    OS << "\t.section\t" << getSectionName() << ",\"";
> +  if (getCharacteristics() & COFF::IMAGE_SCN_CNT_INITIALIZED_DATA)
> +    OS << 'd';
> +  if (getCharacteristics() & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)
> +    OS << 'b';
>    if (getCharacteristics() & COFF::IMAGE_SCN_MEM_EXECUTE)
>      OS << 'x';
>    if (getCharacteristics() & COFF::IMAGE_SCN_MEM_WRITE)
> @@ -55,10 +59,6 @@ void MCSectionCOFF::PrintSwitchToSection
>      OS << 'r';
>    else
>      OS << 'y';
> -  if (getCharacteristics() & COFF::IMAGE_SCN_CNT_INITIALIZED_DATA)
> -    OS << 'd';
> -  if (getCharacteristics() & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)
> -    OS << 'b';
>    if (getCharacteristics() & COFF::IMAGE_SCN_LNK_REMOVE)
>      OS << 'n';
>    if (getCharacteristics() & COFF::IMAGE_SCN_MEM_SHARED)
>
> Modified: llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll Sat Feb  7
> 02:26:40 2015
> @@ -10,6 +10,6 @@ entry:
>    ret void
>  }
>
> -; CHECK: .section .rdata,"rd"
> +; CHECK: .section .rdata,"dr"
>  ; CHECK-NOT: .section ".rodata.str1.1"
>
>
> Modified: llvm/trunk/test/CodeGen/ARM/Windows/structors.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/Windows/structors.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/Windows/structors.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/Windows/structors.ll Sat Feb  7 02:26:40
> 2015
> @@ -7,6 +7,6 @@ entry:
>    ret void
>  }
>
> -; CHECK: .section .CRT$XCU,"rd"
> +; CHECK: .section .CRT$XCU,"dr"
>  ; CHECK: .long function
>
>
> Modified: llvm/trunk/test/CodeGen/X86/coff-comdat.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/coff-comdat.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/coff-comdat.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/coff-comdat.ll Sat Feb  7 02:26:40 2015
> @@ -73,20 +73,20 @@ $vftable = comdat largest
>  ; CHECK: .globl  @v8 at 0
>  ; CHECK: .section        .text,"xr",discard, at f8@0
>  ; CHECK: .globl  @f8 at 0
> -; CHECK: .section        .bss,"wb",associative,_f1
> +; CHECK: .section        .bss,"bw",associative,_f1
>  ; CHECK: .globl  _v1
> -; CHECK: .section        .bss,"wb",associative,_f2
> +; CHECK: .section        .bss,"bw",associative,_f2
>  ; CHECK: .globl  _v2
> -; CHECK: .section        .bss,"wb",associative,_f3
> +; CHECK: .section        .bss,"bw",associative,_f3
>  ; CHECK: .globl  _v3
> -; CHECK: .section        .bss,"wb",associative,_f4
> +; CHECK: .section        .bss,"bw",associative,_f4
>  ; CHECK: .globl  _v4
> -; CHECK: .section        .bss,"wb",associative,_f5
> +; CHECK: .section        .bss,"bw",associative,_f5
>  ; CHECK: .globl  _v5
> -; CHECK: .section        .bss,"wb",associative,_f6
> +; CHECK: .section        .bss,"bw",associative,_f6
>  ; CHECK: .globl  _v6
> -; CHECK: .section        .bss,"wb",same_size,_f6
> +; CHECK: .section        .bss,"bw",same_size,_f6
>  ; CHECK: .globl  _f6
> -; CHECK: .section        .rdata,"rd",largest,_vftable
> +; CHECK: .section        .rdata,"dr",largest,_vftable
>  ; CHECK: .globl  _vftable
>  ; CHECK: _vftable = L_some_name+4
>
> Modified: llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll Sat Feb  7 02:26:40
> 2015
> @@ -37,7 +37,7 @@ define weak_odr dllexport void @weak1()
>  ; CHECK: .globl Var1
>  @Var1 = dllexport global i32 1, align 4
>
> -; CHECK: .rdata,"rd"
> +; CHECK: .rdata,"dr"
>  ; CHECK: .globl Var2
>  @Var2 = dllexport unnamed_addr constant i32 1
>
>
> Modified: llvm/trunk/test/CodeGen/X86/dllexport.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/dllexport.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/dllexport.ll Sat Feb  7 02:26:40 2015
> @@ -58,7 +58,7 @@ define weak_odr dllexport void @weak1()
>  ; CHECK: .globl _Var1
>  @Var1 = dllexport global i32 1, align 4
>
> -; CHECK: .rdata,"rd"
> +; CHECK: .rdata,"dr"
>  ; CHECK: .globl _Var2
>  @Var2 = dllexport unnamed_addr constant i32 1
>
>
> Modified: llvm/trunk/test/CodeGen/X86/global-sections.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/global-sections.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/global-sections.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/global-sections.ll Sat Feb  7 02:26:40 2015
> @@ -48,7 +48,7 @@ define void @F1() {
>  ; LINUX-SECTIONS: .section        .rodata.G3,"a", at progbits
>  ; LINUX-SECTIONS: .globl  G3
>
> -; WIN32-SECTIONS: .section        .rdata,"rd",one_only,_G3
> +; WIN32-SECTIONS: .section        .rdata,"dr",one_only,_G3
>  ; WIN32-SECTIONS: .globl  _G3
>
>
> @@ -124,7 +124,7 @@ define void @F1() {
>  ; LINUX-SECTIONS: .section        .rodata.str1.1,"aMS", at progbits,1
>  ; LINUX-SECTIONS:       .globl G7
>
> -; WIN32-SECTIONS: .section        .rdata,"rd",one_only,_G7
> +; WIN32-SECTIONS: .section        .rdata,"dr",one_only,_G7
>  ; WIN32-SECTIONS:       .globl _G7
>
>
> @@ -187,7 +187,7 @@ define void @F1() {
>  ; LINUX-SECTIONS:        .asciz  "foo"
>  ; LINUX-SECTIONS:        .size   .LG14, 4
>
> -; WIN32-SECTIONS:        .section        .rdata,"rd"
> +; WIN32-SECTIONS:        .section        .rdata,"dr"
>  ; WIN32-SECTIONS: L_G14:
>  ; WIN32-SECTIONS:        .asciz  "foo"
>
> @@ -209,5 +209,5 @@ define void @F1() {
>  ; LINUX-SECTIONS: .section      .rodata.cst8,"aM", at progbits,8
>  ; LINUX-SECTIONS: G15:
>
> -; WIN32-SECTIONS: .section      .rdata,"rd",one_only,_G15
> +; WIN32-SECTIONS: .section      .rdata,"dr",one_only,_G15
>  ; WIN32-SECTIONS: _G15:
>
> Modified: llvm/trunk/test/CodeGen/X86/win_cst_pool.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/win_cst_pool.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/win_cst_pool.ll (original)
> +++ llvm/trunk/test/CodeGen/X86/win_cst_pool.ll Sat Feb  7 02:26:40 2015
> @@ -6,7 +6,7 @@ define double @double() {
>    ret double 0x0000000000800000
>  }
>  ; CHECK:              .globl  __real at 0000000000800000
> -; CHECK-NEXT:         .section
> .rdata,"rd",discard,__real at 0000000000800000
> +; CHECK-NEXT:         .section
> .rdata,"dr",discard,__real at 0000000000800000
>  ; CHECK-NEXT:         .align  8
>  ; CHECK-NEXT: __real at 0000000000800000:
>  ; CHECK-NEXT:         .quad   8388608
> @@ -18,7 +18,7 @@ define <4 x i32> @vec1() {
>    ret <4 x i32> <i32 3, i32 2, i32 1, i32 0>
>  }
>  ; CHECK:              .globl  __xmm at 00000000000000010000000200000003
> -; CHECK-NEXT:         .section
> .rdata,"rd",discard,__xmm at 00000000000000010000000200000003
> +; CHECK-NEXT:         .section
> .rdata,"dr",discard,__xmm at 00000000000000010000000200000003
>  ; CHECK-NEXT:         .align  16
>  ; CHECK-NEXT: __xmm at 00000000000000010000000200000003:
>  ; CHECK-NEXT:         .long   3
> @@ -33,7 +33,7 @@ define <8 x i16> @vec2() {
>    ret <8 x i16> <i16 7, i16 6, i16 5, i16 4, i16 3, i16 2, i16 1, i16 0>
>  }
>  ; CHECK:             .globl  __xmm at 00000001000200030004000500060007
> -; CHECK-NEXT:        .section
> .rdata,"rd",discard,__xmm at 00000001000200030004000500060007
> +; CHECK-NEXT:        .section
> .rdata,"dr",discard,__xmm at 00000001000200030004000500060007
>  ; CHECK-NEXT:        .align  16
>  ; CHECK-NEXT: __xmm at 00000001000200030004000500060007:
>  ; CHECK-NEXT:        .short  7
> @@ -53,7 +53,7 @@ define <4 x float> @undef1() {
>    ret <4 x float> <float 1.0, float 1.0, float undef, float undef>
>
>  ; CHECK:             .globl  __xmm at 00000000000000003f8000003f800000
> -; CHECK-NEXT:        .section
> .rdata,"rd",discard,__xmm at 00000000000000003f8000003f800000
> +; CHECK-NEXT:        .section
> .rdata,"dr",discard,__xmm at 00000000000000003f8000003f800000
>  ; CHECK-NEXT:        .align  16
>  ; CHECK-NEXT: __xmm at 00000000000000003f8000003f800000:
>  ; CHECK-NEXT:        .long   1065353216              # float 1
>
> Modified: llvm/trunk/test/DebugInfo/COFF/asm.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/asm.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/COFF/asm.ll (original)
> +++ llvm/trunk/test/DebugInfo/COFF/asm.ll Sat Feb  7 02:26:40 2015
> @@ -22,7 +22,7 @@
>  ; X86-NEXT: L{{.*}}:
>  ; X86-NEXT: [[END_OF_F:^L.*]]:
>  ;
> -; X86-LABEL: .section        .debug$S,"rd"
> +; X86-LABEL: .section        .debug$S,"dr"
>  ; X86-NEXT: .long   4
>  ; Symbol subsection
>  ; X86-NEXT: .long   241
> @@ -127,7 +127,7 @@
>  ; X64-NEXT: .L{{.*}}:
>  ; X64-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X64-LABEL: .section        .debug$S,"rd"
> +; X64-LABEL: .section        .debug$S,"dr"
>  ; X64-NEXT: .long   4
>  ; Symbol subsection
>  ; X64-NEXT: .long   241
>
> Modified: llvm/trunk/test/DebugInfo/COFF/multifile.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/multifile.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/COFF/multifile.ll (original)
> +++ llvm/trunk/test/DebugInfo/COFF/multifile.ll Sat Feb  7 02:26:40 2015
> @@ -29,7 +29,7 @@
>  ; X86-NEXT: L{{.*}}:
>  ; X86-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X86-LABEL: .section        .debug$S,"rd"
> +; X86-LABEL: .section        .debug$S,"dr"
>  ; X86-NEXT: .long   4
>  ; Symbol subsection
>  ; X86-NEXT: .long   241
> @@ -159,7 +159,7 @@
>  ; X64-NEXT: .L{{.*}}:
>  ; X64-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X64-LABEL: .section        .debug$S,"rd"
> +; X64-LABEL: .section        .debug$S,"dr"
>  ; X64-NEXT: .long   4
>  ; Symbol subsection
>  ; X64-NEXT: .long   241
>
> Modified: llvm/trunk/test/DebugInfo/COFF/multifunction.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/multifunction.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/COFF/multifunction.ll (original)
> +++ llvm/trunk/test/DebugInfo/COFF/multifunction.ll Sat Feb  7 02:26:40
> 2015
> @@ -53,7 +53,7 @@
>  ; X86-NEXT: L{{.*}}:
>  ; X86-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X86-LABEL: .section        .debug$S,"rd"
> +; X86-LABEL: .section        .debug$S,"dr"
>  ; X86-NEXT: .long   4
>  ; Symbol subsection for x
>  ; X86-NEXT: .long   241
> @@ -317,7 +317,7 @@
>  ; X64-NEXT: .L{{.*}}:
>  ; X64-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X64-LABEL: .section        .debug$S,"rd"
> +; X64-LABEL: .section        .debug$S,"dr"
>  ; X64-NEXT: .long   4
>  ; Symbol subsection for x
>  ; X64-NEXT: .long   241
>
> Modified: llvm/trunk/test/DebugInfo/COFF/simple.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/simple.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/COFF/simple.ll (original)
> +++ llvm/trunk/test/DebugInfo/COFF/simple.ll Sat Feb  7 02:26:40 2015
> @@ -20,7 +20,7 @@
>  ; X86-NEXT: L{{.*}}:
>  ; X86-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X86-LABEL: .section        .debug$S,"rd"
> +; X86-LABEL: .section        .debug$S,"dr"
>  ; X86-NEXT: .long   4
>  ; Symbol subsection
>  ; X86-NEXT: .long   241
> @@ -118,7 +118,7 @@
>  ; X64-NEXT: .L{{.*}}:
>  ; X64-NEXT: [[END_OF_F:.*]]:
>  ;
> -; X64-LABEL: .section        .debug$S,"rd"
> +; X64-LABEL: .section        .debug$S,"dr"
>  ; X64-NEXT: .long   4
>  ; Symbol subsection
>  ; X64-NEXT: .long   241
>
> Modified:
> llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll
> (original)
> +++ llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll Sat
> Feb  7 02:26:40 2015
> @@ -22,7 +22,7 @@
>  ; X86-NEXT: [[END_OF_BAR:^L.*]]:{{$}}
>  ; X86-NOT:  ret
>
> -; X86-LABEL: .section        .debug$S,"rd"
> +; X86-LABEL: .section        .debug$S,"dr"
>  ; X86:       .secrel32 "?bar@@YAXHZZ"
>  ; X86-NEXT:  .secidx   "?bar@@YAXHZZ"
>  ; X86:       .long   0
>
> Modified: llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll (original)
> +++ llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll Sat Feb  7
> 02:26:40 2015
> @@ -6,7 +6,7 @@
>  ; CHECK:    .section  .apple_types
>
>  ; RUN: llc -mtriple=i686-pc-win32 -filetype=asm -O0 < %s | FileCheck
> -check-prefix=WIN32 %s
> -; WIN32:    .section .debug$S,"rd"
> +; WIN32:    .section .debug$S,"dr"
>
>  ; RUN: llc -mtriple=i686-pc-win32 -filetype=null -O0 < %s
>
>
> Modified: llvm/trunk/test/MC/COFF/bss_section.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/bss_section.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/MC/COFF/bss_section.ll (original)
> +++ llvm/trunk/test/MC/COFF/bss_section.ll Sat Feb  7 02:26:40 2015
> @@ -7,4 +7,4 @@
>
>  $thingy_linkonce = comdat any
>  @thingy_linkonce = linkonce_odr global %struct.foo zeroinitializer,
> comdat, align 4
> -; CHECK: .section .bss,"wb",discard,_thingy_linkonce
> +; CHECK: .section .bss,"bw",discard,_thingy_linkonce
>
> Modified: llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll (original)
> +++ llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll Sat Feb  7 02:26:40
> 2015
> @@ -5,7 +5,7 @@ define void @f() {
>  }
>
>  @ptr = constant void ()* @f, section ".CRT$XLB", align 8
> -; CHECK:  .section  .CRT$XLB,"rd"
> +; CHECK:  .section  .CRT$XLB,"dr"
>
>  @weak_array = weak_odr unnamed_addr constant [1 x i8*] [i8* bitcast (void
> ()* @f to i8*)]
> -; CHECK:  .section  .rdata,"rd"
> +; CHECK:  .section  .rdata,"dr"
>
> Modified: llvm/trunk/test/MC/COFF/global_ctors_dtors.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/global_ctors_dtors.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/MC/COFF/global_ctors_dtors.ll (original)
> +++ llvm/trunk/test/MC/COFF/global_ctors_dtors.ll Sat Feb  7 02:26:40 2015
> @@ -49,17 +49,17 @@ define i32 @main() nounwind {
>    ret i32 0
>  }
>
> -; WIN32: .section .CRT$XCU,"rd"
> +; WIN32: .section .CRT$XCU,"dr"
>  ; WIN32: a_global_ctor
> -; WIN32: .section .CRT$XCU,"rd",associative,{{_?}}b
> +; WIN32: .section .CRT$XCU,"dr",associative,{{_?}}b
>  ; WIN32: b_global_ctor
>  ; WIN32-NOT: c_global_ctor
> -; WIN32: .section .CRT$XTX,"rd"
> +; WIN32: .section .CRT$XTX,"dr"
>  ; WIN32: a_global_dtor
> -; MINGW32: .section .ctors,"wd"
> +; MINGW32: .section .ctors,"dw"
>  ; MINGW32: a_global_ctor
> -; MINGW32: .section .ctors,"wd",associative,{{_?}}b
> +; MINGW32: .section .ctors,"dw",associative,{{_?}}b
>  ; MINGW32: b_global_ctor
>  ; MINGW32-NOT: c_global_ctor
> -; MINGW32: .section .dtors,"wd"
> +; MINGW32: .section .dtors,"dw"
>  ; MINGW32: a_global_dtor
>
> Modified: llvm/trunk/test/MC/COFF/initialised-data.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/initialised-data.ll?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/MC/COFF/initialised-data.ll (original)
> +++ llvm/trunk/test/MC/COFF/initialised-data.ll Sat Feb  7 02:26:40 2015
> @@ -3,5 +3,5 @@
>
>  @data = dllexport constant [5 x i8] c"data\00", align 1
>
> -; CHECK: .section      .rdata,"rd"
> +; CHECK: .section      .rdata,"dr"
>
>
> Modified: llvm/trunk/test/MC/COFF/section-passthru-flags.s
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/section-passthru-flags.s?rev=228490&r1=228489&r2=228490&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/MC/COFF/section-passthru-flags.s (original)
> +++ llvm/trunk/test/MC/COFF/section-passthru-flags.s Sat Feb  7 02:26:40
> 2015
> @@ -3,5 +3,5 @@
>  // CHECK: .section .klaatu,"wn"
>  .section .barada,"y"
>  // CHECK: .section .barada,"y"
> -.section .nikto,"wds"
> -// CHECK: .section .nikto,"wds"
> +.section .nikto,"dws"
> +// CHECK: .section .nikto,"dws"
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150207/7b7c7db5/attachment.html>


More information about the llvm-commits mailing list