<div dir="ltr">Hans,<div><br></div><div>Can you please merge this into the release branch?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Feb 7, 2015 at 12:26 AM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Sat Feb 7 02:26:40 2015<br>
New Revision: 228490<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=228490&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=228490&view=rev</a><br>
Log:<br>
MC: Emit COFF section flags in the "proper" order<br>
<br>
COFF section flags are not idempotent:<br>
'rd' will make a read-write section because 'd' implies write<br>
'dr' will make a read-only section because 'r' disables write<br>
<br>
Modified:<br>
llvm/trunk/lib/MC/MCSectionCOFF.cpp<br>
llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll<br>
llvm/trunk/test/CodeGen/ARM/Windows/structors.ll<br>
llvm/trunk/test/CodeGen/X86/coff-comdat.ll<br>
llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll<br>
llvm/trunk/test/CodeGen/X86/dllexport.ll<br>
llvm/trunk/test/CodeGen/X86/global-sections.ll<br>
llvm/trunk/test/CodeGen/X86/win_cst_pool.ll<br>
llvm/trunk/test/DebugInfo/COFF/asm.ll<br>
llvm/trunk/test/DebugInfo/COFF/multifile.ll<br>
llvm/trunk/test/DebugInfo/COFF/multifunction.ll<br>
llvm/trunk/test/DebugInfo/COFF/simple.ll<br>
llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll<br>
llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll<br>
llvm/trunk/test/MC/COFF/bss_section.ll<br>
llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll<br>
llvm/trunk/test/MC/COFF/global_ctors_dtors.ll<br>
llvm/trunk/test/MC/COFF/initialised-data.ll<br>
llvm/trunk/test/MC/COFF/section-passthru-flags.s<br>
<br>
Modified: llvm/trunk/lib/MC/MCSectionCOFF.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSectionCOFF.cpp?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSectionCOFF.cpp?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCSectionCOFF.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCSectionCOFF.cpp Sat Feb 7 02:26:40 2015<br>
@@ -47,6 +47,10 @@ void MCSectionCOFF::PrintSwitchToSection<br>
}<br>
<br>
OS << "\t.section\t" << getSectionName() << ",\"";<br>
+ if (getCharacteristics() & COFF::IMAGE_SCN_CNT_INITIALIZED_DATA)<br>
+ OS << 'd';<br>
+ if (getCharacteristics() & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)<br>
+ OS << 'b';<br>
if (getCharacteristics() & COFF::IMAGE_SCN_MEM_EXECUTE)<br>
OS << 'x';<br>
if (getCharacteristics() & COFF::IMAGE_SCN_MEM_WRITE)<br>
@@ -55,10 +59,6 @@ void MCSectionCOFF::PrintSwitchToSection<br>
OS << 'r';<br>
else<br>
OS << 'y';<br>
- if (getCharacteristics() & COFF::IMAGE_SCN_CNT_INITIALIZED_DATA)<br>
- OS << 'd';<br>
- if (getCharacteristics() & COFF::IMAGE_SCN_CNT_UNINITIALIZED_DATA)<br>
- OS << 'b';<br>
if (getCharacteristics() & COFF::IMAGE_SCN_LNK_REMOVE)<br>
OS << 'n';<br>
if (getCharacteristics() & COFF::IMAGE_SCN_MEM_SHARED)<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/Windows/read-only-data.ll Sat Feb 7 02:26:40 2015<br>
@@ -10,6 +10,6 @@ entry:<br>
ret void<br>
}<br>
<br>
-; CHECK: .section .rdata,"rd"<br>
+; CHECK: .section .rdata,"dr"<br>
; CHECK-NOT: .section ".rodata.str1.1"<br>
<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/Windows/structors.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/Windows/structors.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/Windows/structors.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/ARM/Windows/structors.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/Windows/structors.ll Sat Feb 7 02:26:40 2015<br>
@@ -7,6 +7,6 @@ entry:<br>
ret void<br>
}<br>
<br>
-; CHECK: .section .CRT$XCU,"rd"<br>
+; CHECK: .section .CRT$XCU,"dr"<br>
; CHECK: .long function<br>
<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/coff-comdat.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/coff-comdat.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/coff-comdat.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/coff-comdat.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/coff-comdat.ll Sat Feb 7 02:26:40 2015<br>
@@ -73,20 +73,20 @@ $vftable = comdat largest<br>
; CHECK: .globl @v8@0<br>
; CHECK: .section .text,"xr",discard,@f8@0<br>
; CHECK: .globl @f8@0<br>
-; CHECK: .section .bss,"wb",associative,_f1<br>
+; CHECK: .section .bss,"bw",associative,_f1<br>
; CHECK: .globl _v1<br>
-; CHECK: .section .bss,"wb",associative,_f2<br>
+; CHECK: .section .bss,"bw",associative,_f2<br>
; CHECK: .globl _v2<br>
-; CHECK: .section .bss,"wb",associative,_f3<br>
+; CHECK: .section .bss,"bw",associative,_f3<br>
; CHECK: .globl _v3<br>
-; CHECK: .section .bss,"wb",associative,_f4<br>
+; CHECK: .section .bss,"bw",associative,_f4<br>
; CHECK: .globl _v4<br>
-; CHECK: .section .bss,"wb",associative,_f5<br>
+; CHECK: .section .bss,"bw",associative,_f5<br>
; CHECK: .globl _v5<br>
-; CHECK: .section .bss,"wb",associative,_f6<br>
+; CHECK: .section .bss,"bw",associative,_f6<br>
; CHECK: .globl _v6<br>
-; CHECK: .section .bss,"wb",same_size,_f6<br>
+; CHECK: .section .bss,"bw",same_size,_f6<br>
; CHECK: .globl _f6<br>
-; CHECK: .section .rdata,"rd",largest,_vftable<br>
+; CHECK: .section .rdata,"dr",largest,_vftable<br>
; CHECK: .globl _vftable<br>
; CHECK: _vftable = L_some_name+4<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/dllexport-x86_64.ll Sat Feb 7 02:26:40 2015<br>
@@ -37,7 +37,7 @@ define weak_odr dllexport void @weak1()<br>
; CHECK: .globl Var1<br>
@Var1 = dllexport global i32 1, align 4<br>
<br>
-; CHECK: .rdata,"rd"<br>
+; CHECK: .rdata,"dr"<br>
; CHECK: .globl Var2<br>
@Var2 = dllexport unnamed_addr constant i32 1<br>
<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/dllexport.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/dllexport.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/dllexport.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/dllexport.ll Sat Feb 7 02:26:40 2015<br>
@@ -58,7 +58,7 @@ define weak_odr dllexport void @weak1()<br>
; CHECK: .globl _Var1<br>
@Var1 = dllexport global i32 1, align 4<br>
<br>
-; CHECK: .rdata,"rd"<br>
+; CHECK: .rdata,"dr"<br>
; CHECK: .globl _Var2<br>
@Var2 = dllexport unnamed_addr constant i32 1<br>
<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/global-sections.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/global-sections.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/global-sections.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/global-sections.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/global-sections.ll Sat Feb 7 02:26:40 2015<br>
@@ -48,7 +48,7 @@ define void @F1() {<br>
; LINUX-SECTIONS: .section .rodata.G3,"a",@progbits<br>
; LINUX-SECTIONS: .globl G3<br>
<br>
-; WIN32-SECTIONS: .section .rdata,"rd",one_only,_G3<br>
+; WIN32-SECTIONS: .section .rdata,"dr",one_only,_G3<br>
; WIN32-SECTIONS: .globl _G3<br>
<br>
<br>
@@ -124,7 +124,7 @@ define void @F1() {<br>
; LINUX-SECTIONS: .section .rodata.str1.1,"aMS",@progbits,1<br>
; LINUX-SECTIONS: .globl G7<br>
<br>
-; WIN32-SECTIONS: .section .rdata,"rd",one_only,_G7<br>
+; WIN32-SECTIONS: .section .rdata,"dr",one_only,_G7<br>
; WIN32-SECTIONS: .globl _G7<br>
<br>
<br>
@@ -187,7 +187,7 @@ define void @F1() {<br>
; LINUX-SECTIONS: .asciz "foo"<br>
; LINUX-SECTIONS: .size .LG14, 4<br>
<br>
-; WIN32-SECTIONS: .section .rdata,"rd"<br>
+; WIN32-SECTIONS: .section .rdata,"dr"<br>
; WIN32-SECTIONS: L_G14:<br>
; WIN32-SECTIONS: .asciz "foo"<br>
<br>
@@ -209,5 +209,5 @@ define void @F1() {<br>
; LINUX-SECTIONS: .section .rodata.cst8,"aM",@progbits,8<br>
; LINUX-SECTIONS: G15:<br>
<br>
-; WIN32-SECTIONS: .section .rdata,"rd",one_only,_G15<br>
+; WIN32-SECTIONS: .section .rdata,"dr",one_only,_G15<br>
; WIN32-SECTIONS: _G15:<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/win_cst_pool.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/win_cst_pool.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/win_cst_pool.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/win_cst_pool.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/win_cst_pool.ll Sat Feb 7 02:26:40 2015<br>
@@ -6,7 +6,7 @@ define double @double() {<br>
ret double 0x0000000000800000<br>
}<br>
; CHECK: .globl __real@0000000000800000<br>
-; CHECK-NEXT: .section .rdata,"rd",discard,__real@0000000000800000<br>
+; CHECK-NEXT: .section .rdata,"dr",discard,__real@0000000000800000<br>
; CHECK-NEXT: .align 8<br>
; CHECK-NEXT: __real@0000000000800000:<br>
; CHECK-NEXT: .quad 8388608<br>
@@ -18,7 +18,7 @@ define <4 x i32> @vec1() {<br>
ret <4 x i32> <i32 3, i32 2, i32 1, i32 0><br>
}<br>
; CHECK: .globl __xmm@00000000000000010000000200000003<br>
-; CHECK-NEXT: .section .rdata,"rd",discard,__xmm@00000000000000010000000200000003<br>
+; CHECK-NEXT: .section .rdata,"dr",discard,__xmm@00000000000000010000000200000003<br>
; CHECK-NEXT: .align 16<br>
; CHECK-NEXT: __xmm@00000000000000010000000200000003:<br>
; CHECK-NEXT: .long 3<br>
@@ -33,7 +33,7 @@ define <8 x i16> @vec2() {<br>
ret <8 x i16> <i16 7, i16 6, i16 5, i16 4, i16 3, i16 2, i16 1, i16 0><br>
}<br>
; CHECK: .globl __xmm@00000001000200030004000500060007<br>
-; CHECK-NEXT: .section .rdata,"rd",discard,__xmm@00000001000200030004000500060007<br>
+; CHECK-NEXT: .section .rdata,"dr",discard,__xmm@00000001000200030004000500060007<br>
; CHECK-NEXT: .align 16<br>
; CHECK-NEXT: __xmm@00000001000200030004000500060007:<br>
; CHECK-NEXT: .short 7<br>
@@ -53,7 +53,7 @@ define <4 x float> @undef1() {<br>
ret <4 x float> <float 1.0, float 1.0, float undef, float undef><br>
<br>
; CHECK: .globl __xmm@00000000000000003f8000003f800000<br>
-; CHECK-NEXT: .section .rdata,"rd",discard,__xmm@00000000000000003f8000003f800000<br>
+; CHECK-NEXT: .section .rdata,"dr",discard,__xmm@00000000000000003f8000003f800000<br>
; CHECK-NEXT: .align 16<br>
; CHECK-NEXT: __xmm@00000000000000003f8000003f800000:<br>
; CHECK-NEXT: .long 1065353216 # float 1<br>
<br>
Modified: llvm/trunk/test/DebugInfo/COFF/asm.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/asm.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/asm.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/COFF/asm.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/COFF/asm.ll Sat Feb 7 02:26:40 2015<br>
@@ -22,7 +22,7 @@<br>
; X86-NEXT: L{{.*}}:<br>
; X86-NEXT: [[END_OF_F:^L.*]]:<br>
;<br>
-; X86-LABEL: .section .debug$S,"rd"<br>
+; X86-LABEL: .section .debug$S,"dr"<br>
; X86-NEXT: .long 4<br>
; Symbol subsection<br>
; X86-NEXT: .long 241<br>
@@ -127,7 +127,7 @@<br>
; X64-NEXT: .L{{.*}}:<br>
; X64-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X64-LABEL: .section .debug$S,"rd"<br>
+; X64-LABEL: .section .debug$S,"dr"<br>
; X64-NEXT: .long 4<br>
; Symbol subsection<br>
; X64-NEXT: .long 241<br>
<br>
Modified: llvm/trunk/test/DebugInfo/COFF/multifile.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/multifile.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/multifile.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/COFF/multifile.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/COFF/multifile.ll Sat Feb 7 02:26:40 2015<br>
@@ -29,7 +29,7 @@<br>
; X86-NEXT: L{{.*}}:<br>
; X86-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X86-LABEL: .section .debug$S,"rd"<br>
+; X86-LABEL: .section .debug$S,"dr"<br>
; X86-NEXT: .long 4<br>
; Symbol subsection<br>
; X86-NEXT: .long 241<br>
@@ -159,7 +159,7 @@<br>
; X64-NEXT: .L{{.*}}:<br>
; X64-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X64-LABEL: .section .debug$S,"rd"<br>
+; X64-LABEL: .section .debug$S,"dr"<br>
; X64-NEXT: .long 4<br>
; Symbol subsection<br>
; X64-NEXT: .long 241<br>
<br>
Modified: llvm/trunk/test/DebugInfo/COFF/multifunction.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/multifunction.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/multifunction.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/COFF/multifunction.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/COFF/multifunction.ll Sat Feb 7 02:26:40 2015<br>
@@ -53,7 +53,7 @@<br>
; X86-NEXT: L{{.*}}:<br>
; X86-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X86-LABEL: .section .debug$S,"rd"<br>
+; X86-LABEL: .section .debug$S,"dr"<br>
; X86-NEXT: .long 4<br>
; Symbol subsection for x<br>
; X86-NEXT: .long 241<br>
@@ -317,7 +317,7 @@<br>
; X64-NEXT: .L{{.*}}:<br>
; X64-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X64-LABEL: .section .debug$S,"rd"<br>
+; X64-LABEL: .section .debug$S,"dr"<br>
; X64-NEXT: .long 4<br>
; Symbol subsection for x<br>
; X64-NEXT: .long 241<br>
<br>
Modified: llvm/trunk/test/DebugInfo/COFF/simple.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/simple.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/simple.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/COFF/simple.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/COFF/simple.ll Sat Feb 7 02:26:40 2015<br>
@@ -20,7 +20,7 @@<br>
; X86-NEXT: L{{.*}}:<br>
; X86-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X86-LABEL: .section .debug$S,"rd"<br>
+; X86-LABEL: .section .debug$S,"dr"<br>
; X86-NEXT: .long 4<br>
; Symbol subsection<br>
; X86-NEXT: .long 241<br>
@@ -118,7 +118,7 @@<br>
; X64-NEXT: .L{{.*}}:<br>
; X64-NEXT: [[END_OF_F:.*]]:<br>
;<br>
-; X64-LABEL: .section .debug$S,"rd"<br>
+; X64-LABEL: .section .debug$S,"dr"<br>
; X64-NEXT: .long 4<br>
; Symbol subsection<br>
; X64-NEXT: .long 241<br>
<br>
Modified: llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/COFF/tail-call-without-lexical-scopes.ll Sat Feb 7 02:26:40 2015<br>
@@ -22,7 +22,7 @@<br>
; X86-NEXT: [[END_OF_BAR:^L.*]]:{{$}}<br>
; X86-NOT: ret<br>
<br>
-; X86-LABEL: .section .debug$S,"rd"<br>
+; X86-LABEL: .section .debug$S,"dr"<br>
; X86: .secrel32 "?bar@@YAXHZZ"<br>
; X86-NEXT: .secidx "?bar@@YAXHZZ"<br>
; X86: .long 0<br>
<br>
Modified: llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll (original)<br>
+++ llvm/trunk/test/DebugInfo/X86/coff_debug_info_type.ll Sat Feb 7 02:26:40 2015<br>
@@ -6,7 +6,7 @@<br>
; CHECK: .section .apple_types<br>
<br>
; RUN: llc -mtriple=i686-pc-win32 -filetype=asm -O0 < %s | FileCheck -check-prefix=WIN32 %s<br>
-; WIN32: .section .debug$S,"rd"<br>
+; WIN32: .section .debug$S,"dr"<br>
<br>
; RUN: llc -mtriple=i686-pc-win32 -filetype=null -O0 < %s<br>
<br>
<br>
Modified: llvm/trunk/test/MC/COFF/bss_section.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/bss_section.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/bss_section.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/COFF/bss_section.ll (original)<br>
+++ llvm/trunk/test/MC/COFF/bss_section.ll Sat Feb 7 02:26:40 2015<br>
@@ -7,4 +7,4 @@<br>
<br>
$thingy_linkonce = comdat any<br>
@thingy_linkonce = linkonce_odr global %struct.foo zeroinitializer, comdat, align 4<br>
-; CHECK: .section .bss,"wb",discard,_thingy_linkonce<br>
+; CHECK: .section .bss,"bw",discard,_thingy_linkonce<br>
<br>
Modified: llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll (original)<br>
+++ llvm/trunk/test/MC/COFF/const-gv-with-rel-init.ll Sat Feb 7 02:26:40 2015<br>
@@ -5,7 +5,7 @@ define void @f() {<br>
}<br>
<br>
@ptr = constant void ()* @f, section ".CRT$XLB", align 8<br>
-; CHECK: .section .CRT$XLB,"rd"<br>
+; CHECK: .section .CRT$XLB,"dr"<br>
<br>
@weak_array = weak_odr unnamed_addr constant [1 x i8*] [i8* bitcast (void ()* @f to i8*)]<br>
-; CHECK: .section .rdata,"rd"<br>
+; CHECK: .section .rdata,"dr"<br>
<br>
Modified: llvm/trunk/test/MC/COFF/global_ctors_dtors.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/global_ctors_dtors.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/global_ctors_dtors.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/COFF/global_ctors_dtors.ll (original)<br>
+++ llvm/trunk/test/MC/COFF/global_ctors_dtors.ll Sat Feb 7 02:26:40 2015<br>
@@ -49,17 +49,17 @@ define i32 @main() nounwind {<br>
ret i32 0<br>
}<br>
<br>
-; WIN32: .section .CRT$XCU,"rd"<br>
+; WIN32: .section .CRT$XCU,"dr"<br>
; WIN32: a_global_ctor<br>
-; WIN32: .section .CRT$XCU,"rd",associative,{{_?}}b<br>
+; WIN32: .section .CRT$XCU,"dr",associative,{{_?}}b<br>
; WIN32: b_global_ctor<br>
; WIN32-NOT: c_global_ctor<br>
-; WIN32: .section .CRT$XTX,"rd"<br>
+; WIN32: .section .CRT$XTX,"dr"<br>
; WIN32: a_global_dtor<br>
-; MINGW32: .section .ctors,"wd"<br>
+; MINGW32: .section .ctors,"dw"<br>
; MINGW32: a_global_ctor<br>
-; MINGW32: .section .ctors,"wd",associative,{{_?}}b<br>
+; MINGW32: .section .ctors,"dw",associative,{{_?}}b<br>
; MINGW32: b_global_ctor<br>
; MINGW32-NOT: c_global_ctor<br>
-; MINGW32: .section .dtors,"wd"<br>
+; MINGW32: .section .dtors,"dw"<br>
; MINGW32: a_global_dtor<br>
<br>
Modified: llvm/trunk/test/MC/COFF/initialised-data.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/initialised-data.ll?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/initialised-data.ll?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/COFF/initialised-data.ll (original)<br>
+++ llvm/trunk/test/MC/COFF/initialised-data.ll Sat Feb 7 02:26:40 2015<br>
@@ -3,5 +3,5 @@<br>
<br>
@data = dllexport constant [5 x i8] c"data\00", align 1<br>
<br>
-; CHECK: .section .rdata,"rd"<br>
+; CHECK: .section .rdata,"dr"<br>
<br>
<br>
Modified: llvm/trunk/test/MC/COFF/section-passthru-flags.s<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/section-passthru-flags.s?rev=228490&r1=228489&r2=228490&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/COFF/section-passthru-flags.s?rev=228490&r1=228489&r2=228490&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/MC/COFF/section-passthru-flags.s (original)<br>
+++ llvm/trunk/test/MC/COFF/section-passthru-flags.s Sat Feb 7 02:26:40 2015<br>
@@ -3,5 +3,5 @@<br>
// CHECK: .section .klaatu,"wn"<br>
.section .barada,"y"<br>
// CHECK: .section .barada,"y"<br>
-.section .nikto,"wds"<br>
-// CHECK: .section .nikto,"wds"<br>
+.section .nikto,"dws"<br>
+// CHECK: .section .nikto,"dws"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>