[llvm] r227648 - Remove the last vestiges of resetOperationActions.

[Bill Wendling]

+11111111111111

On Fri, Jan 30, 2015, 4:25 PM Eric Christopher <echristo at gmail.com> wrote:

> Author: echristo
> Date: Fri Jan 30 18:21:17 2015
> New Revision: 227648
>
> URL: http://llvm.org/viewvc/llvm-project?rev=227648&view=rev
> Log:
> Remove the last vestiges of resetOperationActions.
>
> Modified:
>     llvm/trunk/include/llvm/Target/TargetLowering.h
>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>     llvm/trunk/lib/Target/X86/X86ISelLowering.h
>
> Modified: llvm/trunk/include/llvm/Target/TargetLowering.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/
> llvm/Target/TargetLowering.h?rev=227648&r1=227647&r2=227648&view=diff
> ============================================================
> ==================
> --- llvm/trunk/include/llvm/Target/TargetLowering.h (original)
> +++ llvm/trunk/include/llvm/Target/TargetLowering.h Fri Jan 30 18:21:17
> 2015
> @@ -1089,10 +1089,6 @@ public:
>    // TargetLowering Configuration Methods - These methods should be
> invoked by
>    // the derived class constructor to configure this object for the
> target.
>    //
> -
> -  /// \brief Reset the operation actions based on target options.
> -  virtual void resetOperationActions() {}
> -
>  protected:
>    /// Specify how the target extends the result of integer and floating
> point
>    /// boolean values from i1 to a wider type.  See getBooleanContents.
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/
> X86/X86ISelLowering.cpp?rev=227648&r1=227647&r2=227648&view=diff
> ============================================================
> ==================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Jan 30 18:21:17 2015
> @@ -202,8 +202,6 @@ static SDValue Concat256BitVectors(SDVal
>    return Insert256BitVector(V, V2, NumElems/2, DAG, dl);
>  }
>
> -// FIXME: This should stop caching the target machine as soon as
> -// we can remove resetOperationActions et al.
>  X86TargetLowering::X86TargetLowering(const X86TargetMachine &TM)
>      : TargetLowering(TM) {
>    Subtarget = &TM.getSubtarget<X86Subtarget>();
> @@ -211,25 +209,6 @@ X86TargetLowering::X86TargetLowering(con
>    X86ScalarSSEf32 = Subtarget->hasSSE1();
>    TD = getDataLayout();
>
> -  resetOperationActions();
> -}
> -
> -void X86TargetLowering::resetOperationActions() {
> -  const TargetMachine &TM = getTargetMachine();
> -  static bool FirstTimeThrough = true;
> -
> -  // If none of the target options have changed, then we don't need to
> reset the
> -  // operation actions.
> -  if (!FirstTimeThrough && TO == TM.Options) return;
> -
> -  if (!FirstTimeThrough) {
> -    // Reinitialize the actions.
> -    initActions();
> -    FirstTimeThrough = false;
> -  }
> -
> -  TO = TM.Options;
> -
>    // Set up the TargetLowering object.
>    static const MVT IntVTs[] = { MVT::i8, MVT::i16, MVT::i32, MVT::i64 };
>
>
> Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/
> X86/X86ISelLowering.h?rev=227648&r1=227647&r2=227648&view=diff
> ============================================================
> ==================
> --- llvm/trunk/lib/Target/X86/X86ISelLowering.h (original)
> +++ llvm/trunk/lib/Target/X86/X86ISelLowering.h Fri Jan 30 18:21:17 2015
> @@ -834,9 +834,6 @@ namespace llvm {
>
>      bool isNoopAddrSpaceCast(unsigned SrcAS, unsigned DestAS) const
> override;
>
> -    /// \brief Reset the operation actions based on target options.
> -    void resetOperationActions() override;
> -
>      bool useLoadStackGuardNode() const override;
>      /// \brief Customize the preferred legalization strategy for certain
> types.
>      LegalizeTypeAction getPreferredVectorAction(EVT VT) const override;
> @@ -851,10 +848,6 @@ namespace llvm {
>      const X86Subtarget *Subtarget;
>      const DataLayout *TD;
>
> -    /// Used to store the TargetOptions so that we don't waste time
> resetting
> -    /// the operation actions unless we have to.
> -    TargetOptions TO;
> -
>      /// Select between SSE or x87 floating point ops.
>      /// When SSE is available, use it for f32 operations.
>      /// When SSE2 is available, use it for f64 operations.
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150131/2ea10ab6/attachment.html>