<p dir="ltr">+11111111111111</p>
<br><div class="gmail_quote">On Fri, Jan 30, 2015, 4:25 PM Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: echristo<br>
Date: Fri Jan 30 18:21:17 2015<br>
New Revision: 227648<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=227648&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=227648&view=rev</a><br>
Log:<br>
Remove the last vestiges of resetOperationActions.<br>
<br>
Modified:<br>
llvm/trunk/include/llvm/<u></u>Target/TargetLowering.h<br>
llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp<br>
llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.h<br>
<br>
Modified: llvm/trunk/include/llvm/<u></u>Target/TargetLowering.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetLowering.h?rev=227648&r1=227647&r2=227648&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/include/<u></u>llvm/Target/TargetLowering.h?<u></u>rev=227648&r1=227647&r2=<u></u>227648&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/include/llvm/<u></u>Target/TargetLowering.h (original)<br>
+++ llvm/trunk/include/llvm/<u></u>Target/TargetLowering.h Fri Jan 30 18:21:17 2015<br>
@@ -1089,10 +1089,6 @@ public:<br>
// TargetLowering Configuration Methods - These methods should be invoked by<br>
// the derived class constructor to configure this object for the target.<br>
//<br>
-<br>
- /// \brief Reset the operation actions based on target options.<br>
- virtual void resetOperationActions() {}<br>
-<br>
protected:<br>
/// Specify how the target extends the result of integer and floating point<br>
/// boolean values from i1 to a wider type. See getBooleanContents.<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=227648&r1=227647&r2=227648&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>X86/X86ISelLowering.cpp?rev=<u></u>227648&r1=227647&r2=227648&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.cpp Fri Jan 30 18:21:17 2015<br>
@@ -202,8 +202,6 @@ static SDValue Concat256BitVectors(SDVal<br>
return Insert256BitVector(V, V2, NumElems/2, DAG, dl);<br>
}<br>
<br>
-// FIXME: This should stop caching the target machine as soon as<br>
-// we can remove resetOperationActions et al.<br>
X86TargetLowering::<u></u>X86TargetLowering(const X86TargetMachine &TM)<br>
: TargetLowering(TM) {<br>
Subtarget = &TM.getSubtarget<X86Subtarget><u></u>();<br>
@@ -211,25 +209,6 @@ X86TargetLowering::<u></u>X86TargetLowering(con<br>
X86ScalarSSEf32 = Subtarget->hasSSE1();<br>
TD = getDataLayout();<br>
<br>
- resetOperationActions();<br>
-}<br>
-<br>
-void X86TargetLowering::<u></u>resetOperationActions() {<br>
- const TargetMachine &TM = getTargetMachine();<br>
- static bool FirstTimeThrough = true;<br>
-<br>
- // If none of the target options have changed, then we don't need to reset the<br>
- // operation actions.<br>
- if (!FirstTimeThrough && TO == TM.Options) return;<br>
-<br>
- if (!FirstTimeThrough) {<br>
- // Reinitialize the actions.<br>
- initActions();<br>
- FirstTimeThrough = false;<br>
- }<br>
-<br>
- TO = TM.Options;<br>
-<br>
// Set up the TargetLowering object.<br>
static const MVT IntVTs[] = { MVT::i8, MVT::i16, MVT::i32, MVT::i64 };<br>
<br>
<br>
Modified: llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.h?rev=227648&r1=227647&r2=227648&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>X86/X86ISelLowering.h?rev=<u></u>227648&r1=227647&r2=227648&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.h (original)<br>
+++ llvm/trunk/lib/Target/X86/<u></u>X86ISelLowering.h Fri Jan 30 18:21:17 2015<br>
@@ -834,9 +834,6 @@ namespace llvm {<br>
<br>
bool isNoopAddrSpaceCast(unsigned SrcAS, unsigned DestAS) const override;<br>
<br>
- /// \brief Reset the operation actions based on target options.<br>
- void resetOperationActions() override;<br>
-<br>
bool useLoadStackGuardNode() const override;<br>
/// \brief Customize the preferred legalization strategy for certain types.<br>
LegalizeTypeAction getPreferredVectorAction(EVT VT) const override;<br>
@@ -851,10 +848,6 @@ namespace llvm {<br>
const X86Subtarget *Subtarget;<br>
const DataLayout *TD;<br>
<br>
- /// Used to store the TargetOptions so that we don't waste time resetting<br>
- /// the operation actions unless we have to.<br>
- TargetOptions TO;<br>
-<br>
/// Select between SSE or x87 floating point ops.<br>
/// When SSE is available, use it for f32 operations.<br>
/// When SSE2 is available, use it for f64 operations.<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>