[llvm] r221915 - Object, Mach-O: Refactor and clean code up

[Rafael Espíndola]

ping.

Felipe's work has improved things in here, but the attached patch still
passes all tests.


On 10 December 2014 at 14:35, Rafael Espíndola <rafael.espindola at gmail.com>
wrote:

> On 18 November 2014 at 21:04, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
> >> -      assert(!DataInCodeLoadCmd && "Multiple data in code tables");
> >> +      // Multiple data in code tables
> >> +      if (DataInCodeLoadCmd) {
> >> +        EC = object_error::parse_failed;
> >> +        return;
> >> +      }
> >
> > Do you have a testcase for this? As with COFF, an assert/unreachable
> > is better unless we have a test showing how this is actually reached.
>
> Ping.
>
> I can revert this patch (revert attached) and check-all still passes.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150123/f787253f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: t.patch
Type: text/x-patch
Size: 1979 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150123/f787253f/attachment.bin>