[PATCH] [zorg] Rev1: Fix get slave environment in LLDB Windows builder.

[Rick Foos]

Ready to go.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:56
@@ -46,1 +55,3 @@
+            # Default values for VS devenv and build configuration
+            vs_common=r"%VS120COMNTOOLS%",
             config='Release',
----------------
This allows VS versions to be selected by env variable or a hardcoded path to a place where ..\..\VC\vcvarsall.bat can be found.

I'd prefer when we refactor to allow the entire slave command to be specified here. This would replace all the function of generateVisualStudioEnvironment.

I've used the command to set a path to a 64 bit python in addition to the VS dev environment for a specific builder. A full command also leaves it compatible with linux as printenv works with this routine as well.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:62
@@ -50,1 +61,3 @@
+            test='ignoreFail',
+            install=True):
 
----------------
Both test and install can be disabled here.

Additionally, the test step can be marked ignoreFail'ures. This executes the tests, but ignores the failures.

All the builds will be green whether tests pass or fail. This is what we do here until experimental tests are working.

The defaults for test and install are on for now, and the builder can select if something different is needed.

http://reviews.llvm.org/D7077

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/