[PATCH] [zorg] Rev1: Fix get slave environment in LLDB Windows builder.

[Galina]

Thanks for working on this, Rick!

If I get it right, this will be refactored once http://reviews.llvm.org/D6866 is in place. With this in mind, the patch looks good to me, assuming you will make the tests optional to reduce the immediate noise of the tests false failures.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:127-132
@@ -123,1 +126,8 @@
 
+    f.addStep(ShellCommand(name='install',
+                          command=[ninja_cmd,'install'],
+                          haltOnFailure=False,
+                          description='ninja install',
+                          workdir=build_dir,
+                          env=Property('slave_env')))
+
----------------
rfoos wrote:
> zturner wrote:
> > Is the install necessary?  What happens if we don't install?  I've never done it before, so it seems like an unnecessary step unless I'm missing something.
> The current CMake install step doesn't copy over the python DLL, or site-packages, and there is no info inside the exe on where to find them.
> 
> Doing the install step exposes these problems. But you need to get the installed version from the buildslave manually to see there is something wrong.
> 
> In the future, adding the ability to run the installed version of LLDB through LIT would be useful.
I'm second on this. We should do the formal install and use the installed result for testing.
This would help exposing missing dependencies.
With few exceptions when the install takes too long or requires too much resources on a particular slave. Though, this is not a subject of this particular patch.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:134-140
@@ +133,9 @@
+
+    f.addStep(ShellCommand(name='test',
+                          command=[ninja_cmd,'check-lldb'],
+                          haltOnFailure=False,
+                          flunkOnFailure=False,
+                          description='ninja test',
+                          workdir=build_dir,
+                          env=Property('slave_env')))
+
----------------
zturner wrote:
> rfoos wrote:
> > zturner wrote:
> > > Can getLLDBWindowsCMAKEBuildFactory take a boolean that says whether to run tests?
> > Yes, but one of the goals of this build factory was to put in place additions so that LLDB could run tests on Windows.
> Yes but right now most of the tests still fail and haven't yet been marked XFAIL.  So it would be nice if we could leave the tests off until we get that sorted out, so that we can at least verify the tree remains green in the meantime.  Otherwise the builder will just be red all the time.  Also eventually we will have multiple bots, and we may want some bots that only test compilation with different settings, and then have one master configuration that runs tests.  To save CPU cycles on the machine for example.
Not sure about boolean, but agree in general. It should be a graceful way to skip tests for a particular builder.

http://reviews.llvm.org/D7077

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/