[llvm] r226694 - Fix a compile issue on MSVC and call finalize().

David Blaikie dblaikie at gmail.com
Wed Jan 21 11:40:07 PST 2015


On Wed, Jan 21, 2015 at 11:25 AM, Adrian Prantl <aprantl at apple.com> wrote:

> Author: adrian
> Date: Wed Jan 21 13:25:35 2015
> New Revision: 226694
>
> URL: http://llvm.org/viewvc/llvm-project?rev=226694&view=rev
> Log:
> Fix a compile issue on MSVC and call finalize().
>
> Modified:
>     llvm/trunk/unittests/IR/IRBuilderTest.cpp
>
> Modified: llvm/trunk/unittests/IR/IRBuilderTest.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/IRBuilderTest.cpp?rev=226694&r1=226693&r2=226694&view=diff
>
> ==============================================================================
> --- llvm/trunk/unittests/IR/IRBuilderTest.cpp (original)
> +++ llvm/trunk/unittests/IR/IRBuilderTest.cpp Wed Jan 21 13:25:35 2015
> @@ -294,7 +294,9 @@ TEST_F(IRBuilderTest, DIBuilder) {
>    auto File = DIB.createFile("F.CBL", "/");
>    auto CU = DIB.createCompileUnit(dwarf::DW_LANG_Cobol74, "F.CBL", "/",
>                                    "llvm-cobol74", true, "", 0);
> -  auto Type = DIB.createSubroutineType(File,
> DIB.getOrCreateTypeArray({}));
> +  auto Type =
> +    DIB.createSubroutineType(File,
> +
>  DIB.getOrCreateTypeArray(ArrayRef<Metadata*>()));
>

Empty ArrayRefs can be implicitly constructed from the special "None"
object:

  getOrCreateTypeArray(None)


>    auto SP = DIB.createFunction(CU, "foo", "", File, 1, Type,
>                                 false, true, 1, 0, true, F);
>    EXPECT_TRUE(SP.Verify());
> @@ -302,6 +304,7 @@ TEST_F(IRBuilderTest, DIBuilder) {
>    auto BadScope = DIB.createLexicalBlockFile(DIDescriptor(), File, 0);
>    I->setDebugLoc(DebugLoc::get(2, 0, BadScope));
>    EXPECT_FALSE(SP.Verify());
> +  DIB.finalize();
>  }
>
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/a9bcf95e/attachment.html>


More information about the llvm-commits mailing list