<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 21, 2015 at 11:25 AM, Adrian Prantl <span dir="ltr"><<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: adrian<br>
Date: Wed Jan 21 13:25:35 2015<br>
New Revision: 226694<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=226694&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=226694&view=rev</a><br>
Log:<br>
Fix a compile issue on MSVC and call finalize().<br>
<br>
Modified:<br>
    llvm/trunk/unittests/IR/IRBuilderTest.cpp<br>
<br>
Modified: llvm/trunk/unittests/IR/IRBuilderTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/IRBuilderTest.cpp?rev=226694&r1=226693&r2=226694&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/IR/IRBuilderTest.cpp?rev=226694&r1=226693&r2=226694&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/unittests/IR/IRBuilderTest.cpp (original)<br>
+++ llvm/trunk/unittests/IR/IRBuilderTest.cpp Wed Jan 21 13:25:35 2015<br>
@@ -294,7 +294,9 @@ TEST_F(IRBuilderTest, DIBuilder) {<br>
   auto File = DIB.createFile("F.CBL", "/");<br>
   auto CU = DIB.createCompileUnit(dwarf::DW_LANG_Cobol74, "F.CBL", "/",<br>
                                   "llvm-cobol74", true, "", 0);<br>
-  auto Type = DIB.createSubroutineType(File, DIB.getOrCreateTypeArray({}));<br>
+  auto Type =<br>
+    DIB.createSubroutineType(File,<br>
+                             DIB.getOrCreateTypeArray(ArrayRef<Metadata*>()));<br></blockquote><div><br>Empty ArrayRefs can be implicitly constructed from the special "None" object:<br><br>  getOrCreateTypeArray(None)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   auto SP = DIB.createFunction(CU, "foo", "", File, 1, Type,<br>
                                false, true, 1, 0, true, F);<br>
   EXPECT_TRUE(SP.Verify());<br>
@@ -302,6 +304,7 @@ TEST_F(IRBuilderTest, DIBuilder) {<br>
   auto BadScope = DIB.createLexicalBlockFile(DIDescriptor(), File, 0);<br>
   I->setDebugLoc(DebugLoc::get(2, 0, BadScope));<br>
   EXPECT_FALSE(SP.Verify());<br>
+  DIB.finalize();<br>
 }<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>