[PATCH] [mips] Fix 'jumpy' debug line info around calls.

[David Blaikie]

On Wed, Jan 21, 2015 at 9:40 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

>  > > On Wed, Jan 21, 2015 at 7:37 AM, Daniel Sanders <
> daniel.sanders at imgtec.com> wrote:
>
> > > Previous revision deleted a little too much and it started passing
> without the
> > > fix. Brought back one more function call.
>
> >
> > Why were 2 calls insufficient?
>
>
>
> The first spurious '.loc 3' we are looking for is always omitted because
> the previous call is on line 3 too.
>

Ah - you could catch that more directly by checking that the address
calculation comes after the loc4, not before it.


> With a third call, a second spurious '.loc 3' will appear between the
> second and third calls.
>
>   *From:* David Blaikie [mailto:dblaikie at gmail.com]
> *Sent:* 21 January 2015 17:07
> *To:* reviews+D7050+public+e22ff8356bd9a5ae at reviews.llvm.org
> *Cc:* Daniel Sanders; Vladimir Medic; llvm-commits at cs.uiuc.edu;
> ehostunreach at gmail.com
> *Subject:* Re: [PATCH] [mips] Fix 'jumpy' debug line info around calls.
>
>
>
>
>
>
>
> On Wed, Jan 21, 2015 at 7:37 AM, Daniel Sanders <daniel.sanders at imgtec.com>
> wrote:
>
> Previous revision deleted a little too much and it started passing without
> the
> fix. Brought back one more function call.
>
>
> Why were 2 calls insufficient?
>
>
>
>
> http://reviews.llvm.org/D7050
>
> Files:
>   lib/Target/Mips/Mips16ISelLowering.cpp
>   lib/Target/Mips/MipsISelLowering.cpp
>   lib/Target/Mips/MipsISelLowering.h
>
>   test/DebugInfo/Mips/fn-call-line.ll
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150121/14f49912/attachment.html>