[patch][pr19848] Don't create new comdats in CodeGen

[David Majnemer]

I guess the additional loop over all the GlobalObjects doesn't add much.
I'll LGTM the earlier version.

On Tue, Jan 13, 2015 at 2:47 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

>
> > On 2015-Jan-13, at 14:35, Rafael Espíndola <rafael.espindola at gmail.com>
> wrote:
> >
> > On 12 January 2015 at 21:25, Rafael Espíndola
> > <rafael.espindola at gmail.com> wrote:
> >>> OK, that makes sense.  It would be nice to assert that no
> GlobalObjects that
> >>> should've had their Comdat filled in were missed.
> >>
> >> Any idea on how to do it? I can only think of walking all of ValueList
> >> at the end of ParseValueSymbolTable. Would that be worth it?
> >
> > If you think it is, the attached patch does it.
>
> Should the `for` loop be wrapped in an `#ifndef NDEBUG`?
>
> > Let me know which one you prefer.
>
> (I'll leave this up to David.)
>
> >
> > Cheers,
> > Rafael
> > <t.patch>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150113/06f68578/attachment.html>