[PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 2

Michael Kuperstein michael.m.kuperstein at intel.com
Tue Jan 13 06:33:25 PST 2015


So, this version should actually work (e.g. it can self-host and past check-llvm. Without the stackalign restriction of course, since that currently makes it a nop except on windows).
Unfortunately, it has several big warts, so I'm not planning to commit it as is. This is more of a request for ideas on how to improve the code.

So, any ideas on how to make this sane, especially X86InstrInfo::getSPAdjust(), are welcome.


http://reviews.llvm.org/D6789

Files:
  lib/CodeGen/PrologEpilogInserter.cpp
  lib/Target/X86/CMakeLists.txt
  lib/Target/X86/X86.h
  lib/Target/X86/X86ConvertMovsToPushes.cpp
  lib/Target/X86/X86FastISel.cpp
  lib/Target/X86/X86FrameLowering.cpp
  lib/Target/X86/X86FrameLowering.h
  lib/Target/X86/X86InstrCompiler.td
  lib/Target/X86/X86InstrInfo.cpp
  lib/Target/X86/X86InstrInfo.h
  lib/Target/X86/X86MachineFunctionInfo.h
  lib/Target/X86/X86RegisterInfo.cpp
  lib/Target/X86/X86TargetMachine.cpp
  test/CodeGen/X86/inalloca-invoke.ll
  test/CodeGen/X86/movtopush.ll

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6789.18084.patch
Type: text/x-patch
Size: 42114 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150113/eddada74/attachment.bin>


More information about the llvm-commits mailing list