[PATCH] [X86] Convert esp-relative movs of function arguments to pushes, step 2

Reid Kleckner rnk at google.com
Mon Jan 12 16:02:57 PST 2015


================
Comment at: lib/Target/X86/X86ConvertMovsToPushes.cpp:39
@@ +38,3 @@
+
+cl::opt<bool> NoMovToPush("no-mov-to-push",
+              cl::desc("Avoid function argument mov-to-push transformation"),
----------------
mkuper wrote:
> delena wrote:
> > I don't think that we really need this knob.
> I'd rather keep this knob, it's fairly useful for debugging.
> Of course, it's internal only, not exposed to clang.
I would also like this as a temporary testing knob so that I can evaluate this across a large codebase.

http://reviews.llvm.org/D6789

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list