[lld] r225766 - Remove InputGraph::dump().

[Rui Ueyama]

I don't think so. The implementation of dump() for InputGraph is empty (the
member function just returns true), and no subclasses redefine the
function. So it was no-op even before this patch.

On Mon, Jan 12, 2015 at 9:20 PM, Saleem Abdulrasool <compnerd at compnerd.org>
wrote:

> On Mon, Jan 12, 2015 at 9:11 PM, Rui Ueyama <ruiu at google.com> wrote:
>
>> Author: ruiu
>> Date: Mon Jan 12 23:11:05 2015
>> New Revision: 225766
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=225766&view=rev
>> Log:
>> Remove InputGraph::dump().
>>
>> This is dead code.
>>
>
> Isn't this the standard debugging helper for use in the debugger?
>
>
>> Modified:
>>     lld/trunk/include/lld/Core/InputGraph.h
>>     lld/trunk/lib/Core/InputGraph.cpp
>>     lld/trunk/lib/Driver/GnuLdDriver.cpp
>>
>> Modified: lld/trunk/include/lld/Core/InputGraph.h
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/InputGraph.h?rev=225766&r1=225765&r2=225766&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/include/lld/Core/InputGraph.h (original)
>> +++ lld/trunk/include/lld/Core/InputGraph.h Mon Jan 12 23:11:05 2015
>> @@ -83,9 +83,6 @@ public:
>>    // \brief Returns the number of input files.
>>    size_t size() const { return _inputArgs.size(); }
>>
>> -  /// \brief Dump the input Graph
>> -  bool dump(raw_ostream &diagnostics = llvm::errs());
>> -
>>  protected:
>>    // Input arguments
>>    InputElementVectorT _inputArgs;
>>
>> Modified: lld/trunk/lib/Core/InputGraph.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/InputGraph.cpp?rev=225766&r1=225765&r2=225766&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/lib/Core/InputGraph.cpp (original)
>> +++ lld/trunk/lib/Core/InputGraph.cpp Mon Jan 12 23:11:05 2015
>> @@ -48,13 +48,6 @@ void InputGraph::addInputElementFront(st
>>    _inputArgs.insert(_inputArgs.begin(), std::move(ie));
>>  }
>>
>> -bool InputGraph::dump(raw_ostream &diagnostics) {
>> -  for (std::unique_ptr<InputElement> &ie : _inputArgs)
>> -    if (!ie->dump(diagnostics))
>> -      return false;
>> -  return true;
>> -}
>> -
>>  /// \brief Helper functions for the resolver
>>  InputElement *InputGraph::getNextInputElement() {
>>    if (_nextElementIndex >= _inputArgs.size())
>>
>> Modified: lld/trunk/lib/Driver/GnuLdDriver.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/GnuLdDriver.cpp?rev=225766&r1=225765&r2=225766&view=diff
>>
>> ==============================================================================
>> --- lld/trunk/lib/Driver/GnuLdDriver.cpp (original)
>> +++ lld/trunk/lib/Driver/GnuLdDriver.cpp Mon Jan 12 23:11:05 2015
>> @@ -689,9 +689,6 @@ bool GnuLdDriver::parse(int argc, const
>>      }
>>    }
>>
>> -  if (ctx->outputFileType() == LinkingContext::OutputFileType::YAML)
>> -    inputGraph->dump(diagnostics);
>> -
>>    // Validate the combination of options used.
>>    if (!ctx->validate(diagnostics))
>>      return false;
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150112/e5a0ed49/attachment.html>