<div dir="ltr">I don't think so. The implementation of dump() for InputGraph is empty (the member function just returns true), and no subclasses redefine the function. So it was no-op even before this patch.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 12, 2015 at 9:20 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="">On Mon, Jan 12, 2015 at 9:11 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br></span><div class="gmail_extra"><div class="gmail_quote"><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Mon Jan 12 23:11:05 2015<br>
New Revision: 225766<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225766&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=225766&view=rev</a><br>
Log:<br>
Remove InputGraph::dump().<br>
<br>
This is dead code.<br></blockquote><div><br></div></span><div>Isn't this the standard debugging helper for use in the debugger?</div><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
    lld/trunk/include/lld/Core/InputGraph.h<br>
    lld/trunk/lib/Core/InputGraph.cpp<br>
    lld/trunk/lib/Driver/GnuLdDriver.cpp<br>
<br>
Modified: lld/trunk/include/lld/Core/InputGraph.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/InputGraph.h?rev=225766&r1=225765&r2=225766&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/InputGraph.h?rev=225766&r1=225765&r2=225766&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/include/lld/Core/InputGraph.h (original)<br>
+++ lld/trunk/include/lld/Core/InputGraph.h Mon Jan 12 23:11:05 2015<br>
@@ -83,9 +83,6 @@ public:<br>
   // \brief Returns the number of input files.<br>
   size_t size() const { return _inputArgs.size(); }<br>
<br>
-  /// \brief Dump the input Graph<br>
-  bool dump(raw_ostream &diagnostics = llvm::errs());<br>
-<br>
 protected:<br>
   // Input arguments<br>
   InputElementVectorT _inputArgs;<br>
<br>
Modified: lld/trunk/lib/Core/InputGraph.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/InputGraph.cpp?rev=225766&r1=225765&r2=225766&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/InputGraph.cpp?rev=225766&r1=225765&r2=225766&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/Core/InputGraph.cpp (original)<br>
+++ lld/trunk/lib/Core/InputGraph.cpp Mon Jan 12 23:11:05 2015<br>
@@ -48,13 +48,6 @@ void InputGraph::addInputElementFront(st<br>
   _inputArgs.insert(_inputArgs.begin(), std::move(ie));<br>
 }<br>
<br>
-bool InputGraph::dump(raw_ostream &diagnostics) {<br>
-  for (std::unique_ptr<InputElement> &ie : _inputArgs)<br>
-    if (!ie->dump(diagnostics))<br>
-      return false;<br>
-  return true;<br>
-}<br>
-<br>
 /// \brief Helper functions for the resolver<br>
 InputElement *InputGraph::getNextInputElement() {<br>
   if (_nextElementIndex >= _inputArgs.size())<br>
<br>
Modified: lld/trunk/lib/Driver/GnuLdDriver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/GnuLdDriver.cpp?rev=225766&r1=225765&r2=225766&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/GnuLdDriver.cpp?rev=225766&r1=225765&r2=225766&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/Driver/GnuLdDriver.cpp (original)<br>
+++ lld/trunk/lib/Driver/GnuLdDriver.cpp Mon Jan 12 23:11:05 2015<br>
@@ -689,9 +689,6 @@ bool GnuLdDriver::parse(int argc, const<br>
     }<br>
   }<br>
<br>
-  if (ctx->outputFileType() == LinkingContext::OutputFileType::YAML)<br>
-    inputGraph->dump(diagnostics);<br>
-<br>
   // Validate the combination of options used.<br>
   if (!ctx->validate(diagnostics))<br>
     return false;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org</div>
</font></span></div></div>
</blockquote></div><br></div>