[llvm] r225720 - Untwine this expression. Thanks to David for noticing!

[David Blaikie]

On Mon, Jan 12, 2015 at 2:39 PM, Adrian Prantl <aprantl at apple.com> wrote:

> Author: adrian
> Date: Mon Jan 12 16:39:14 2015
> New Revision: 225720
>
> URL: http://llvm.org/viewvc/llvm-project?rev=225720&view=rev
> Log:
> Untwine this expression. Thanks to David for noticing!
>
> Modified:
>     llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp?rev=225720&r1=225719&r2=225720&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp (original)
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp Mon Jan 12
> 16:39:14 2015
> @@ -49,7 +49,7 @@ public:
>
>  void DebugLocDwarfExpression::EmitOp(uint8_t Op, const char* Comment) {
>    BS.EmitInt8(Op, Comment
> -    ? Twine(Comment)+Twine(" ")+Twine(dwarf::OperationEncodingString(Op))
> +    ? Twine(Comment)+" "+dwarf::OperationEncodingString(Op)
>

Also, we usually put spaces between the '+' - what does clang-format do to
this whole expression?

  BS.EmitInt8(
      Op, Comment ? Twine(Comment) + " " +
dwarf::OperationEncodingString(Op)
                  : dwarf::OperationEncodingString(Op));


>      : dwarf::OperationEncodingString(Op));
>  }
>  void DebugLocDwarfExpression::EmitSigned(int Value) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150112/5d7a81f9/attachment.html>