<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 12, 2015 at 2:39 PM, Adrian Prantl <span dir="ltr"><<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: adrian<br>
Date: Mon Jan 12 16:39:14 2015<br>
New Revision: 225720<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225720&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=225720&view=rev</a><br>
Log:<br>
Untwine this expression. Thanks to David for noticing!<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp?rev=225720&r1=225719&r2=225720&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp?rev=225720&r1=225719&r2=225720&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp Mon Jan 12 16:39:14 2015<br>
@@ -49,7 +49,7 @@ public:<br>
<br>
 void DebugLocDwarfExpression::EmitOp(uint8_t Op, const char* Comment) {<br>
   BS.EmitInt8(Op, Comment<br>
-    ? Twine(Comment)+Twine(" ")+Twine(dwarf::OperationEncodingString(Op))<br>
+    ? Twine(Comment)+" "+dwarf::OperationEncodingString(Op)<br></blockquote><div><br>Also, we usually put spaces between the '+' - what does clang-format do to this whole expression?<br><br><div><font face="monospace, monospace">  BS.EmitInt8(</font></div><div><font face="monospace, monospace">      Op, Comment ? Twine(Comment) + " " + dwarf::OperationEncodingString(Op)</font></div><div><font face="monospace, monospace">                  : dwarf::OperationEncodingString(Op));</font></div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
     : dwarf::OperationEncodingString(Op));<br>
 }<br>
 void DebugLocDwarfExpression::EmitSigned(int Value) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>