[lld] r225574 - Don't fail if parent directory name contains a '+' character

[Rui Ueyama]

This does not look correct. /[+-_]/ means all characters between '+' and
'_' ('+', ',', and '-' in ASCII). I don't think this is what you meant.

Adding '+' to the set is a bit too hacky. If your path contains a funny
character like '%', '$' or ' ', this test would fail.

It doesn't seems to me that we really need to use a regex here. Does the
following suffice?

EXEC: Undefined symbol: /shared.so-x86-64: puts
SHLIB: Undefined symbol: /shared.so-x86-64: puts
EXEC-NOT: Undefined symbol: /shared.so-x86-64: weakfoo
SHLIB-NOT: Undefined symbol: /shared.so-x86-64: weakfoo

On Sat, Jan 10, 2015 at 11:34 AM, Greg Fitzgerald <gregf at codeaurora.org>
wrote:

> Author: garious
> Date: Fri Jan  9 20:34:26 2015
> New Revision: 225574
>
> URL: http://llvm.org/viewvc/llvm-project?rev=225574&view=rev
> Log:
> Don't fail if parent directory name contains a '+' character
>
> Differential Revision: http://reviews.llvm.org/D6902
>
> Modified:
>     lld/trunk/test/elf/dynamic-undef.test
>     lld/trunk/test/elf/filenotfound.test
>
> Modified: lld/trunk/test/elf/dynamic-undef.test
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/dynamic-undef.test?rev=225574&r1=225573&r2=225574&view=diff
>
> ==============================================================================
> --- lld/trunk/test/elf/dynamic-undef.test (original)
> +++ lld/trunk/test/elf/dynamic-undef.test Fri Jan  9 20:34:26 2015
> @@ -26,9 +26,9 @@ RUN:   %p/Inputs/shared.so-x86-64 -o %t.
>  RUN: --use-shlib-undefines --no-allow-shlib-undefined  2> %t2
>  RUN: llvm-readobj -symbols %t.useundefines | FileCheck
> -check-prefix=SHLIB-UNDEF-SYMBOLS %s
>
> -EXEC: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
> -SHLIB: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
> -EXEC-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64:
> weakfoo
> -SHLIB-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64:
> weakfoo
> +EXEC: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
> +SHLIB: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts
> +EXEC-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64:
> weakfoo
> +SHLIB-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64:
> weakfoo
>  SHLIB-NOUNDEF-NOT: Name: puts
>  SHLIB-UNDEF-SYMBOLS: Name: puts
>
> Modified: lld/trunk/test/elf/filenotfound.test
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/filenotfound.test?rev=225574&r1=225573&r2=225574&view=diff
>
> ==============================================================================
> --- lld/trunk/test/elf/filenotfound.test (original)
> +++ lld/trunk/test/elf/filenotfound.test Fri Jan  9 20:34:26 2015
> @@ -1,3 +1,3 @@
>  # Check that a file that cannot be found results in a proper error message
>  RUN: not lld -flavor gnu -target x86_64 %p/Inputs/nofile.o 2>&1 |
> FileCheck %s
> -#CHECK: lld: cannot find file {{[-_A-Za-z0-9.\\/:]+}}nofile.o
> +#CHECK: lld: cannot find file {{[+-_A-Za-z0-9.\\/:]+}}nofile.o
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150113/3366c5ce/attachment.html>