<div dir="ltr"><div class="gmail_extra">This does not look correct. /[+-_]/ means all characters between '+' and '_' ('+', ',', and '-' in ASCII). I don't think this is what you meant.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Adding '+' to the set is a bit too hacky. If your path contains a funny character like '%', '$' or ' ', this test would fail.</div><div class="gmail_extra"><br></div><div class="gmail_extra">It doesn't seems to me that we really need to use a regex here. Does the following suffice?</div><div class="gmail_extra"><br></div><div class="gmail_extra"><span style="font-size:13px">EXEC: Undefined symbol: /</span><span style="font-size:13px">shared.so-x86-64: puts</span><br style="font-size:13px"><span style="font-size:13px">SHLIB: Undefined symbol: /</span><span style="font-size:13px">shared.so-x86-64: puts</span><br style="font-size:13px"><span style="font-size:13px">EXEC-NOT: Undefined symbol: /</span><span style="font-size:13px">shared.so-x86-64: weakfoo</span><br style="font-size:13px"><span style="font-size:13px">SHLIB-NOT: Undefined symbol: /</span><span style="font-size:13px">shared.so-x86-64: weakfoo</span><br style="font-size:13px"></div><div class="gmail_extra"><span style="font-size:13px"><br></span></div><div class="gmail_extra"><div class="gmail_quote">On Sat, Jan 10, 2015 at 11:34 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: garious<br>
Date: Fri Jan  9 20:34:26 2015<br>
New Revision: 225574<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=225574&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=225574&view=rev</a><br>
Log:<br>
Don't fail if parent directory name contains a '+' character<br>
<br>
Differential Revision: <a href="http://reviews.llvm.org/D6902" target="_blank">http://reviews.llvm.org/D6902</a><br>
<br>
Modified:<br>
    lld/trunk/test/elf/dynamic-undef.test<br>
    lld/trunk/test/elf/filenotfound.test<br>
<br>
Modified: lld/trunk/test/elf/dynamic-undef.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/dynamic-undef.test?rev=225574&r1=225573&r2=225574&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/dynamic-undef.test?rev=225574&r1=225573&r2=225574&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/elf/dynamic-undef.test (original)<br>
+++ lld/trunk/test/elf/dynamic-undef.test Fri Jan  9 20:34:26 2015<br>
@@ -26,9 +26,9 @@ RUN:   %p/Inputs/shared.so-x86-64 -o %t.<br>
 RUN: --use-shlib-undefines --no-allow-shlib-undefined  2> %t2<br>
 RUN: llvm-readobj -symbols %t.useundefines | FileCheck -check-prefix=SHLIB-UNDEF-SYMBOLS %s<br>
<br>
-EXEC: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts<br>
-SHLIB: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts<br>
-EXEC-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo<br>
-SHLIB-NOT: Undefined symbol: {{[-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo<br>
+EXEC: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts<br>
+SHLIB: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: puts<br>
+EXEC-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo<br>
+SHLIB-NOT: Undefined symbol: {{[+-_A-Za-z0-9.\\/:]+}}shared.so-x86-64: weakfoo<br>
 SHLIB-NOUNDEF-NOT: Name: puts<br>
 SHLIB-UNDEF-SYMBOLS: Name: puts<br>
<br>
Modified: lld/trunk/test/elf/filenotfound.test<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/filenotfound.test?rev=225574&r1=225573&r2=225574&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/test/elf/filenotfound.test?rev=225574&r1=225573&r2=225574&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/test/elf/filenotfound.test (original)<br>
+++ lld/trunk/test/elf/filenotfound.test Fri Jan  9 20:34:26 2015<br>
@@ -1,3 +1,3 @@<br>
 # Check that a file that cannot be found results in a proper error message<br>
 RUN: not lld -flavor gnu -target x86_64 %p/Inputs/nofile.o 2>&1 | FileCheck %s<br>
-#CHECK: lld: cannot find file {{[-_A-Za-z0-9.\\/:]+}}nofile.o<br>
+#CHECK: lld: cannot find file {{[+-_A-Za-z0-9.\\/:]+}}nofile.o<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>