[PATCH] Add saving and restoring of r30 to the prologue and epilogue, respectively

hfinkel at anl.gov hfinkel at anl.gov
Wed Jan 7 22:28:18 PST 2015


LGTM.


REPOSITORY
  rL LLVM

================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:647
@@ -646,1 +646,3 @@
 
+  if (isPIC && !isDarwinABI && !isPPC64 && MF.getInfo<PPCFunctionInfo>()->usesPICBase())
+    // FIXME: On PPC32 SVR4, we must not spill before claiming the stackframe.
----------------
This line is too long.

================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:1013
@@ -1005,1 +1012,3 @@
 
+  if (isPIC && !isDarwinABI && !isPPC64 && MF.getInfo<PPCFunctionInfo>()->usesPICBase())
+    // FIXME: On PPC32 SVR4, we must not spill before claiming the stackframe.
----------------
Same here.

http://reviews.llvm.org/D6876

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list