[PATCH] Create an experimental Windows LLDB Builder

Galina gkistanova at gmail.com
Wed Jan 7 09:25:48 PST 2015


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:28
@@ +27,3 @@
+        value = keyval_pair[1]
+        env[key] = value
+
----------------
zturner wrote:
> gkistanova wrote:
> > 1. Having all the env vars from a slave could be too much and noisy in the logs. How about white list only what you really need? This is not a show stopper, though.
> I thought about that, but it's difficult to know exactly which ones we need.  There are some that are obvious, like include paths, library paths, etc, but some that are not so obvious.  In theory we just need to be able find cl.exe, link.exe, and include / library paths, but the use of many of the other variables is kind of mysterious and not well documented by Microsoft, so it's not clear if we will trigger their access somehow.  
> 
> In other words, I can come up with a whitelist but I would not be 100% confident that it would be accurate.
Agree. This could be time consuming. Adding a FIXME: with the description of the issue would do for now.

http://reviews.llvm.org/D6745

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the llvm-commits mailing list