[PATCH] Create an experimental Windows LLDB Builder

[Zachary Turner]

Thanks for the comments.  I will work on a fix for the issues you pointed out.


================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:28
@@ +27,3 @@
+        value = keyval_pair[1]
+        env[key] = value
+
----------------
gkistanova wrote:
> 1. Having all the env vars from a slave could be too much and noisy in the logs. How about white list only what you really need? This is not a show stopper, though.
I thought about that, but it's difficult to know exactly which ones we need.  There are some that are obvious, like include paths, library paths, etc, but some that are not so obvious.  In theory we just need to be able find cl.exe, link.exe, and include / library paths, but the use of many of the other variables is kind of mysterious and not well documented by Microsoft, so it's not clear if we will trigger their access somehow.  

In other words, I can come up with a whitelist but I would not be 100% confident that it would be accurate.

================
Comment at: zorg/buildbot/builders/LLDBBuilder.py:39
@@ +38,3 @@
+            # Source directory containing a built python
+            python_source_dir='C:\\src\\python\\',
+
----------------
gkistanova wrote:
> 2. Could you use raw strings here and everywhere else for Windows paths with dir separators, please? Like r'C:\src\python\'.
Unfortunately it seems like a raw string cannot end with a single backslash.  This might be a bug in python, but I tested it out.  r'C:\src\python\' is an error, and r'C:\src\python\\' actually puts two backslashes at the end.

I can probably change it to not include any backslashes at the end though, and then just make sure that the case of 0 backslashes and 1 backslash are both correctly handled in the function.

http://reviews.llvm.org/D6745

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/