[PATCH] [cmake/multilib] Teach llgo to respect the LLVM_LIBDIR_SUFFIX variable formultilib build and installs.

Peter Collingbourne peter at pcc.me.uk
Mon Dec 29 11:15:04 PST 2014


On Mon, Dec 29, 2014 at 11:01:05AM -0800, Chandler Carruth wrote:
> On Mon, Dec 29, 2014 at 6:40 AM, Peter Collingbourne <peter at pcc.me.uk>
> wrote:
> 
> > I think the right thing to do is to teach the `getVariantDir` function in
> > `gllgo.go` to return an appropriate string (something like
> > `"../lib${LLVM_LIBDIR_SUFFIX}[/sanitizer]"`).
> >
> 
> Why not make it getLibDir and just return
> "lib${LLVM_LIBDIRSUFFIX}/sanitizer"? The 'lib/../lib/.' thing seems
> needlessly roundabout.

That would work too. We would need to arrange for 'llgo
-print-multi-os-directory' to print a '../' prefix as the libgo build system
expects that path to be relative to the lib directory (yuck, but that is
how libgo queries gccgo, and it seems simplest to be consistent).

Thanks,
-- 
Peter



More information about the llvm-commits mailing list