[PATCH] [cmake/multilib] Teach llgo to respect the LLVM_LIBDIR_SUFFIX variable formultilib build and installs.

[Chandler Carruth]

On Mon, Dec 29, 2014 at 6:40 AM, Peter Collingbourne <peter at pcc.me.uk>
wrote:

> I think the right thing to do is to teach the `getVariantDir` function in
> `gllgo.go` to return an appropriate string (something like
> `"../lib${LLVM_LIBDIR_SUFFIX}[/sanitizer]"`).
>

Why not make it getLibDir and just return
"lib${LLVM_LIBDIRSUFFIX}/sanitizer"? The 'lib/../lib/.' thing seems
needlessly roundabout.


> That string should eventually make its way to many of the appropriate
> places including the libgo build system. That and the `initCompiler`
> function looks like everything that needs to be taught about this.
>
> Did you end up exposing `LLVM_LIBDIR_SUFFIX` somewhere like a `#define` in
> a header file? If so, we should be able to pick it up from Go (see e.g.
> `bindings/go/llvm/version.go` for an example of how to do that).
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20141229/c7f84753/attachment.html>